Closed
Bug 890933
Opened 11 years ago
Closed 11 years ago
Stop using sut_reboot to reboot pandas
Categories
(Testing Graveyard :: Mozpool, defect)
Testing Graveyard
Mozpool
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
Details
Attachments
(1 file)
|
(deleted),
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
The SUT reboot process is too unreliable. Since we always have relays, we should just use those.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #774185 -
Flags: review?(mcote)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 774185 [details] [diff] [review]
bug890933.patch
Review of attachment 774185 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine, but we should probably get rid of the TRY_RELAY_AFTER_SUT_COUNT class variable and the self.machine.clear_counter('sut_attempts') call from on_power_cycle_ok() as well, since neither are useful anymore.
Attachment #774185 -
Flags: review?(mcote) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 774185 [details] [diff] [review]
bug890933.patch
Landed with the suggested changes
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•