Closed
Bug 890963
Opened 11 years ago
Closed 11 years ago
Reword unclear string identity.mixed_active_loaded ("view website's behavior")
Categories
(Core :: Security, defect)
Core
Security
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: flod, Assigned: tanvi)
References
Details
Attachments
(3 files, 2 obsolete files)
identity.mixed_active_loaded=This website contains interactive content that isn't encrypted (such as scripts). Other people can view or modify the website's behavior.
Based on Metej's suggestion (see Bug 838402 comment 26)
This website contains interactive content that isn't encrypted (such as scripts). Other people can view the website or modify its behavior.
Note that the string ID must be updated too.
Reporter | ||
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Assignee | ||
Comment 1•11 years ago
|
||
In bug 838402, we settled on "This page contains interactive content that isn't encrypted (such as scripts). Other people can view your information or modify the website's behavior".
Here is a patch that makes that string change.
Attachment #777237 -
Flags: review?(dolske)
Comment 2•11 years ago
|
||
Comment on attachment 777237 [details] [diff] [review]
Update site identity message for Mixed Active Loaded v1
Review of attachment 777237 [details] [diff] [review]:
-----------------------------------------------------------------
String's fine, but you'll be needing to update the code to look for the new property name, no?
Also, the current larry panel doesn't seem to wrap this string (and it's already hilariously too-wide, even in the current UI). Making it longer will likely overflow the screen. We'll need to fix that.
Attachment #777237 -
Flags: review?(dolske) → review-
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Actually I guess the new string isn't actually significantly longer, but we really do need to make this wrap. Either this regressed or we missed it the first time around.
Assignee | ||
Comment 5•11 years ago
|
||
The text doesn't seem to have ever wrapped. I'm looking into how to do that.
Comment 6•11 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #3)
> Created attachment 780133 [details]
> Leon is getting laaaarger.
I thought his name was Larry. Is Leon his new friend?
Updated•11 years ago
|
Assignee: nobody → tanvi
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•11 years ago
|
||
It looks like there is no max-width for the identity box. Adding a max-width so that the content will wrap. I have set it to 50 characters, but could expand or decrease by a few characters if you think that would be better.
Also updated the code to look for the new property name.
Thanks Jared for your help!
Attachment #777237 -
Attachment is obsolete: true
Attachment #783454 -
Flags: review?(dolske)
Assignee | ||
Comment 8•11 years ago
|
||
Comment 9•11 years ago
|
||
Comment on attachment 783454 [details] [diff] [review]
Update site identity message for Mixed Active Loaded v2
Review of attachment 783454 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/themes/linux/browser.css
@@ +1093,5 @@
> max-width: 300px;
> }
>
> +#identity-popup-content-box {
> + max-width:50ch;
nit: max-width: 50ch;
Move this to the bottom of identity-block.inc.css. Moving it to the bottom of identity-block.inc.css will mean that it doesn't need to be copied for each platform.
Attachment #783454 -
Flags: review?(dolske) → feedback+
Assignee | ||
Comment 10•11 years ago
|
||
Updated per Jared's comments.
Attachment #783454 -
Attachment is obsolete: true
Attachment #783463 -
Flags: review?(dolske)
Updated•11 years ago
|
Attachment #783463 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 11•11 years ago
|
||
Thanks for the review Jared!
Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/fa8605750b68
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•