Closed
Bug 891722
Opened 11 years ago
Closed 11 years ago
Media Recording - The rate of ondataavailable events spikes adnormally high after starting, stopping, and starting recording again
Categories
(Core :: Audio/Video: Recording, defect)
Core
Audio/Video: Recording
Tracking
()
VERIFIED
FIXED
mozilla25
People
(Reporter: jsmith, Assigned: rlin)
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
STR:
1. Load the attached test case
2. In the console, type mediaRecorder.start();
3. After a second or two, type mediaRecorder.stop(); in console
4. Now type mediaRecorder.start(); in console
5. Wait a few seconds
Expected
The rate of ondataavailable events coming in should be in the same after starting recording in step #2 vs. step #4.
Actual
The rate of ondataavailable events is adnormally high after step #4 in comparison to step #2. After step #2, waiting a few seconds might have 5 to 6 ondataavailable events. After step #4, waiting a few seconds might have 30+ ondataavailable events.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → rlin
Assignee | ||
Comment 1•11 years ago
|
||
I checked the GetEncodedData() and it returns small bytes array after 2nd start.
Discuss with slin, she says after remove the encoder listener, the status will enter stopped.
So We may need to
1. have a reset function in encoder
2. re-create new encoder and forgot older one.
Hi Roc,
How do you think about this?
Flags: needinfo?(roc)
Comment 2•11 years ago
|
||
Once the encoder is removed from the MediaStreamGraph, it then stops encoding and terminates the container writer. Restart the encoder without re-initializing track encoders and container writer does not function proeprly for the current design.
I think you should recreate the encoder.
Flags: needinfo?(roc)
Assignee | ||
Comment 4•11 years ago
|
||
Always create encoder on start function.
Attachment #775297 -
Flags: review?(roc)
Attachment #775297 -
Flags: review?(roc) → review+
Assignee | ||
Comment 5•11 years ago
|
||
carry reviewer.
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Updated•11 years ago
|
Attachment #775297 -
Attachment is obsolete: true
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cafd483cc3cf
Please fix your hg configuration so your name is set to "Randy Lin <rlin@mozilla.com>" instead of "<Randy Lin> rlin@mozilla.com". Also, a friendly reminder that your commit message should summarize what the patch is doing, not just restate the bug title.
Keywords: checkin-needed
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Reporter | ||
Comment 8•11 years ago
|
||
Tested using comment 0's STR. I'm not seeing the spike immediately on start of recording the 2nd time, but instead, I'm immediately seeing a crash quickly on the 2nd time we record. See bug 894413 for a followup.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Assignee | ||
Updated•11 years ago
|
Blocks: MediaRecording
Updated•11 years ago
|
Component: Video/Audio → Video/Audio: Recording
Reporter | ||
Updated•11 years ago
|
No longer blocks: MediaRecording
You need to log in
before you can comment on or make changes to this bug.
Description
•