Closed
Bug 891786
Opened 11 years ago
Closed 11 years ago
Persona is not applied to find bar after landing bug #537013
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
WONTFIX
People
(Reporter: Virtual, Unassigned)
References
(Depends on 1 open bug)
Details
(Keywords: nightly-community, regression)
like in title
Comment 1•11 years ago
|
||
WFM on the 07/10 Nightly on Windows 7 64bit and Ubuntu 13.04 32bit.
What persona did you use?
Flags: needinfo?(BernesB)
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 2•11 years ago
|
||
Flags: needinfo?(BernesB)
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•11 years ago
|
||
Are we still planning to move the findbar to the top of the page? If so, this becomes wontfix.
Comment 4•11 years ago
|
||
Ah, indeed. bug 869543.
Comment 5•11 years ago
|
||
If I'm reading the patch in bug 869543 correctly, personas won't be applied to the find bar on top either.
Comment 6•11 years ago
|
||
I'm sorry, in my mind personas were being applied to the navigator-toolbox element, not the window element. You can ignore comment 5.
Comment 7•11 years ago
|
||
I was right but for another reason, personas are still not applied to the find bar even on top, it keeps its background color (at least on windows, haven't tried others).
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 8•11 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #3 & comment #4 )
> Are we still planning to move the findbar to the top of the page? If so,
> this becomes wontfix.
> Ah, indeed. bug 869543.
But it didn't bother to also applied Persona to the findbar when it's placed to the top like it was done when it was in bottom.
Even Bookmarks sidebar (CTRL+B) and history sidebar (CTRL+H) have it.
I don't understand this change. Can you elaborate why you removing this feature?
Flags: needinfo?(dolske)
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•11 years ago
|
Flags: needinfo?(dao)
Comment 9•11 years ago
|
||
I don't think it makes sense to apply the persona when it's at the top. (Just like we don't for notification bars.)
Flags: needinfo?(dolske)
Flags: needinfo?(dao)
Comment 10•11 years ago
|
||
(In reply to Virtual_ManPL [:Virtual] from comment #8)
> Even Bookmarks sidebar (CTRL+B) and history sidebar (CTRL+H) have it.
That looks more like a bug to me, it's visually awkward. (Also we don't do it on OS X, and Australis has already fixed this for Windows).
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 11•11 years ago
|
||
OK! Thanks for clarification :)
Status: RESOLVED → VERIFIED
Comment 12•11 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #10)
> (In reply to Virtual_ManPL [:Virtual] from comment #8)
>
> > Even Bookmarks sidebar (CTRL+B) and history sidebar (CTRL+H) have it.
>
> That looks more like a bug to me, it's visually awkward. (Also we don't do
> it on OS X, and Australis has already fixed this for Windows).
To me the bug with that is that OS X doesn't apply the personas to its sidebar. Since my opinion on the matter covers more than just the issue of the find bar in here, and judging from your comment that this seems like a deliberate look for the new Australis theme, I've opened a new bug 897902 to discuss it.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Keywords: nightly-community
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
QA Contact: Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•