Closed Bug 891786 Opened 11 years ago Closed 11 years ago

Persona is not applied to find bar after landing bug #537013

Categories

(Firefox :: General, defect)

25 Branch
x86_64
Windows 7
defect
Not set
major

Tracking

()

VERIFIED WONTFIX

People

(Reporter: Virtual, Unassigned)

References

(Depends on 1 open bug)

Details

(Keywords: nightly-community, regression)

WFM on the 07/10 Nightly on Windows 7 64bit and Ubuntu 13.04 32bit. What persona did you use?
Flags: needinfo?(BernesB)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Are we still planning to move the findbar to the top of the page? If so, this becomes wontfix.
Ah, indeed. bug 869543.
Status: NEW → RESOLVED
Closed: 11 years ago
Depends on: 869543
Resolution: --- → WONTFIX
If I'm reading the patch in bug 869543 correctly, personas won't be applied to the find bar on top either.
I'm sorry, in my mind personas were being applied to the navigator-toolbox element, not the window element. You can ignore comment 5.
I was right but for another reason, personas are still not applied to the find bar even on top, it keeps its background color (at least on windows, haven't tried others).
(In reply to Justin Dolske [:Dolske] from comment #3 & comment #4 ) > Are we still planning to move the findbar to the top of the page? If so, > this becomes wontfix. > Ah, indeed. bug 869543. But it didn't bother to also applied Persona to the findbar when it's placed to the top like it was done when it was in bottom. Even Bookmarks sidebar (CTRL+B) and history sidebar (CTRL+H) have it. I don't understand this change. Can you elaborate why you removing this feature?
Flags: needinfo?(dolske)
I don't think it makes sense to apply the persona when it's at the top. (Just like we don't for notification bars.)
Flags: needinfo?(dolske)
Flags: needinfo?(dao)
(In reply to Virtual_ManPL [:Virtual] from comment #8) > Even Bookmarks sidebar (CTRL+B) and history sidebar (CTRL+H) have it. That looks more like a bug to me, it's visually awkward. (Also we don't do it on OS X, and Australis has already fixed this for Windows).
OK! Thanks for clarification :)
Status: RESOLVED → VERIFIED
(In reply to Justin Dolske [:Dolske] from comment #10) > (In reply to Virtual_ManPL [:Virtual] from comment #8) > > > Even Bookmarks sidebar (CTRL+B) and history sidebar (CTRL+H) have it. > > That looks more like a bug to me, it's visually awkward. (Also we don't do > it on OS X, and Australis has already fixed this for Windows). To me the bug with that is that OS X doesn't apply the personas to its sidebar. Since my opinion on the matter covers more than just the issue of the find bar in here, and judging from your comment that this seems like a deliberate look for the new Australis theme, I've opened a new bug 897902 to discuss it.
You need to log in before you can comment on or make changes to this bug.