Right now we're using the dummy icon for the customize button, and another help icon for the help menu. We should definitely update the customize button, and probably just include the help menu in the sprite as well. Stephen, I'm assigning this to you as we wait for new sprites. :-)

Definitely can't ship with the purple&pink icon!

I suspect this will actually end up being fixed by the implementation of bug 871203, but just marking it as a dependency for the moment.

Any update here Stephen?

Thanks Stephen. I'll carry this forward.

Comment on attachment 803926 [details] [diff] [review] Patch Review of attachment 803926 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/themes/shared/customizableui/panelUIOverlay.inc.css @@ +223,5 @@ > + > +#PanelUI-customize, > +#PanelUI-help, > +#PanelUI-quit { > + -moz-image-region: rect(0, 16px, 16px, 0); I should probably move this block lower so it is directly above the *:hover rules.

Comment on attachment 803926 [details] [diff] [review] Patch Review of attachment 803926 [details] [diff] [review]: ----------------------------------------------------------------- I gave two ideas to remove rulesets from the OS X stylesheet which would be nice but don't block. I also agree with your own note. I didn't test the patches but I have fresh builds on all platforms if you want me to do so when I get to the office. ::: browser/themes/osx/customizableui/panelUIOverlay.css @@ +9,5 @@ > > +#PanelUI-customize:hover, > +#PanelUI-help:hover, > +#PanelUI-quit:hover { > + -moz-image-region: rect(0, 16px, 16px, 0); Notes describing what's happening: This prevents the :hover state on OS X. I personally would prefer an #ifndef XP_MAC around the relevant style in panelUIOverlay.inc.css to reduce duplication. @@ +15,5 @@ > + > +#PanelUI-customize:hover:active, > +#PanelUI-help:hover:active, > +#PanelUI-quit:hover:active { > + -moz-image-region: rect(0, 32px, 16px, 16px); …and the default :hover state is used for :hover:active on OS X or is it that the images have a different layout? If the OS X image is already different than the others, I would prefer just changing the image to have a consistent position for the :hover:active state. That would avoid this block.

I didn't notice that the OS X images already had the same layout as the Windows/Linux images. I was able to remove the two blocks from the osx specialization and will now test it on osx and linux.

https://hg.mozilla.org/projects/ux/rev/809acf2d41bc I talked with Stephen and he wants to use the hover states on OSX. I removed the %ifndef guards and added the HiDPI ruleset for :hover. Tested on linux, windows, and osx.

<jaws> shorlander: you included three states for the help/quit/customize icons on osx. does that mean you want a hover state? or was that just an oversight? <shorlander> jaws: yeah, all the actions are pretty grey. want to try and add some color on hover.

The quit icon is too big on OS X hidpi. :-( (the other two seem fine)

(In reply to :Gijs Kruitbosch from comment #12) > The quit icon is too big on OS X hidpi. :-( > > (the other two seem fine) I don't see anything within this patch to cause this issue. Perhaps there is some other CSS style that is being applied specifically to the quit icon that is making it larger? Can you file a separate bug on this issue when you find more details?

(In reply to Jared Wein [:jaws] from comment #13) > (In reply to :Gijs Kruitbosch from comment #12) > > The quit icon is too big on OS X hidpi. :-( > > > > (the other two seem fine) > > I don't see anything within this patch to cause this issue. Perhaps there is > some other CSS style that is being applied specifically to the quit icon > that is making it larger? Can you file a separate bug on this issue when you > find more details? Filed bug 916873. I also just noticed that the customize button still has the old icon. I clobbered and rebuilt, and it still looks like this. Will probably have to delay investigating until tomorrow, so if anyone feels like picking it up before then, please be my guest.