Closed
Bug 892425
Opened 11 years ago
Closed 11 years ago
Defect - Layout in grid with bookmarks changes after navigation, also displays scrollbars
Categories
(Firefox for Metro Graveyard :: Firefox Start, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 25
People
(Reporter: jimm, Assigned: sfoster)
References
Details
(Whiteboard: feature=defect c=tbd u=tbd p=3)
Attachments
(2 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
Odd quirky bug, STR:
1) have eight bookmarks saved
2) open metrofx
note that bookmarks are laid out in two columns, four bookmarks each.
3) navigate to a site using touch
4) navigate back using the overlay back button
result:
bookmarks are now laid out in a single column, eight bookmarks with the lower bookmark slightly clipped by the nav bar.
5) move the mouse
result: scrollbars on the bookmarks column
reproduced on a Surface Pro.
Updated•11 years ago
|
Summary: Layout in grid with bookmarks changes after navigation, also displays scrollbars → Defect - Layout in grid with bookmarks changes after navigation, also displays scrollbars
Whiteboard: feature=defect c=tbd u=tbd p=0
Updated•11 years ago
|
Priority: -- → P2
Updated•11 years ago
|
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
QA Contact: jbecerra
Whiteboard: feature=defect c=tbd u=tbd p=0 → feature=defect c=tbd u=tbd p=3
Assignee | ||
Comment 1•11 years ago
|
||
The attached fixes the issue for me. Jimm can you confirm? I've left the outline on the bookmarks grid to make it more apparent. Also any feedback on the fix appreciated. Basically I leave space for a possible horizontal scrollbar.
Attachment #781159 -
Flags: feedback?(mbrubeck)
Attachment #781159 -
Flags: feedback?(jmathies)
Updated•11 years ago
|
Attachment #781159 -
Flags: feedback?(mbrubeck) → feedback+
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 781159 [details] [diff] [review]
Stabilize meta-section grid sizing
fixes the problem for me. the grid layout remains unchanged between the nav and the nav back.
Attachment #781159 -
Flags: feedback?(jmathies) → feedback+
Assignee | ||
Comment 3•11 years ago
|
||
Tightens up some of the richgrid sizing rules and logic - we now use the bound node as the reference bounding box if it has flex.
By adding some margin to leave room for a horizontal scrollbar, the available space for the start grids doesn't change so we don't get grid rearranging as the precise/imprecise input value flips.
Attachment #781159 -
Attachment is obsolete: true
Attachment #781258 -
Flags: review?(mbrubeck)
Updated•11 years ago
|
Attachment #781258 -
Attachment is patch: true
Attachment #781258 -
Attachment mime type: message/rfc822 → text/plain
Updated•11 years ago
|
Attachment #781258 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Some merging, then:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aacf8f0ef017
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Comment 6•11 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130806104538
Built from http://hg.mozilla.org/mozilla-central/rev/1e381c91885d
WFM
Tested on windows 8 using latest nightly. Followed steps provided in comment0 and got expected result.
Comment 7•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130815030203
Built from http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc
WFM
Tested on windows 8 using latest nightly for iteration-12. I don't see any issue after using overlay back button.
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•