Bas, can I land this in mozilla-central? It goes into Moz2D and I need it for the textures refactoring.

Comment on attachment 773979 [details] [diff] [review] Implement CreateDataSourceSurface Review of attachment 773979 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/2d/Factory.cpp @@ +504,5 @@ > +TemporaryRef<DataSourceSurface> > +Factory::CreateDataSourceSurface(const IntSize &aSize, > + SurfaceFormat aFormat) > +{ > + int32_t stride = GetAlignedStride<4>(aSize.width * BytesPerPixel(aFormat)); Please use a 16 byte aligned stride. We should ensure 16-byte aligned allocation as well. This will greatly help us utilize fast SSE2 codepaths. (Possibly we should even be considering 32-byte aligned at this point, but using aligned allocation and stride will make this easy to change in the future) Please grab the code for this from the filters branch in Moz2D, it already has a more involved implementation of this :). https://hg.mozilla.org/users/bschouten_mozilla.com/moz2d/file/42a3532d0948/SourceSurfaceRawData.h

Sweet thanks, here is the patch with the code extracted from your Moz2D branch. Can I land it in m-c?

It's not in the uploaded patch but I also extracted the change to this line to get things to compile (casting to T* rather than uint32_t*): https://hg.mozilla.org/users/bschouten_mozilla.com/moz2d/file/42a3532d0948/Tools.h#l116

Comment on attachment 778386 [details] [diff] [review] create-datasourcesurface-v2.patch Review of attachment 778386 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, you should get that casting change too (whoops), this seems great!