Closed
Bug 892647
Opened 11 years ago
Closed 11 years ago
DOMRequestIpcHelperMessageListener is destroyed twice when inner window is destroyed
Categories
(Core Graveyard :: DOM: Apps, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla25
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
The inner-window-destroyed event leads to DOMRequestIpcHelperMessageListener.destroy() being called, which calls DOMRequestIpcHelper.destroy(), which calls back into the message listener destroy(). removeObserver() throws an error.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #774184 -
Flags: review?(justin.lebar+bug)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 774184 [details] [diff] [review]
Add check to prevent destroy actions from running twice.
r=me; thanks for catching this!
Attachment #774184 -
Flags: review?(justin.lebar+bug) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•