Closed
Bug 892856
Opened 11 years ago
Closed 11 years ago
Protobuf fails to build in VS 2013
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
Tracking | Status | |
---|---|---|
firefox28 | --- | fixed |
People
(Reporter: xavier114fch, Assigned: emk)
References
()
Details
(Whiteboard: [qa-])
Attachments
(2 files, 2 obsolete files)
(deleted),
patch
|
mmc
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mmc
:
review+
|
Details | Diff | Splinter Review |
Add missing include for successful building on VS 2013.
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•11 years ago
|
Component: Build Config → General
Comment 1•11 years ago
|
||
fixed by the following changeset
http://code.google.com/p/protobuf/source/detail?r=512
Comment 2•11 years ago
|
||
Attachment #774465 -
Attachment is obsolete: true
Attachment #823237 -
Flags: review?(mmc)
Comment 3•11 years ago
|
||
Comment on attachment 823237 [details] [diff] [review]
import r512
Review of attachment 823237 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you.
Attachment #823237 -
Flags: review?(mmc) → review+
Comment 4•11 years ago
|
||
Target Milestone: --- → mozilla28
Updated•11 years ago
|
Assignee: nobody → m_kato
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•11 years ago
|
||
Still fails to build...
78:14.00 wire_format_lite.cc
78:14.00 h:\m\mozilla-central\toolkit\components\protobuf\google/protobuf/wire_f
ormat_lite_inl.h(270) : error C3861: 'min': 識別子が見つかりませんでした
78:14.00 h:\m\mozilla-central\toolkit\components\protobuf\google/protobu
f/wire_format_lite_inl.h(303) : コンパイルされたクラスの テンプレート のインスタ
ンス化 'bool google::protobuf::internal::WireFormatLite::ReadRepeatedFixedSizePr
imitive<google::protobuf::uint32,TYPE_FIXED32>(int,google::protobuf::uint32,goog
le::protobuf::io::CodedInputStream *,google::protobuf::RepeatedField<google::pro
tobuf::uint32> *)' の参照を確認してください
78:14.02 Native command 'mozbuild.action.cl main' returned value '2'
78:14.13 945 compiler warnings present.
2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 7•11 years ago
|
||
Comment 8•11 years ago
|
||
This last patch worked for me.
Comment 9•11 years ago
|
||
Xavier, can you please update the file r512.patch introduced in https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=892856&attachment=823237?
Otherwise, looks good to me.
Thanks,
Monica
Assignee | ||
Comment 10•11 years ago
|
||
Protobuf no longer fails build in unified mode.
Comment 11•11 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #10)
> Protobuf no longer fails build in unified mode.
This was also WFM in my local unified build.
Assignee | ||
Comment 12•11 years ago
|
||
We still need this for non-unified builds.
Assignee: m_kato → VYV03354
Attachment #827664 -
Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Attachment #8361777 -
Flags: review?(mmc)
Updated•11 years ago
|
Attachment #8361777 -
Flags: review?(mmc) → review+
Comment 13•11 years ago
|
||
Thanks, emk.
Assignee | ||
Comment 14•11 years ago
|
||
Flags: in-testsuite-
Comment 15•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
status-firefox28:
--- → fixed
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•