Closed
Bug 892876
Opened 11 years ago
Closed 11 years ago
AUDIO IN/OUT enums are different between gecko and jb audio
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vasanth, Assigned: vasanth)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
Comparing [1] and [2], shows AUDIO OUT/IN enum values are changed in jb but not yet updated in gecko. This causes FM in jb to use wrong audio output path and fails to play. Attached patch fixes this issue. [1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/android_audio/AudioSystem.h#256 [2] https://git.quicinc.com/?p=platform/system/core.git;a=blob;f=include/system/audio.h;h=8e5443066234307e29f562eacf9eba49afbe5ac9;hb=refs/heads/jb_mr1-stable#l357
(In reply to Michael Vines [:m1] [:evilmachines] from comment #1) > Looks like [2] is an invalid URL, can you please provide one that works? Sorry. Here's the correct url https://www.codeaurora.org/cgit/quic/la/platform/system/core/tree/include/system/audio.h?h=jb_3.1#n357
Updated•11 years ago
|
Attachment #774507 -
Flags: review?(mwu)
Updated•11 years ago
|
Attachment #774507 -
Flags: review?(mwu) → review+
Comment 3•11 years ago
|
||
https://hg.mozilla.org/projects/birch/rev/4289e7eb1826
Whiteboard: [fixed-in-birch]
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4289e7eb1826
Assignee: nobody → vasanth
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Whiteboard: [fixed-in-birch]
You need to log in
before you can comment on or make changes to this bug.
Description
•