Closed
Bug 892979
Opened 11 years ago
Closed 10 years ago
Clicking on the markup view scrolls the view in a weird way
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: paul, Unassigned)
References
(Blocks 1 open bug)
Details
We call scrollIntoViewIfNeeded 3 times after the user clicked on a node. 1st time with centered=false (good), and 2 times with centered=true (bad).
Reporter | ||
Comment 1•11 years ago
|
||
We should not scroll at all if the new selection comes from a mouse event. It's very perturbing to see the markup jumping right under the cursor.
Reporter | ||
Comment 2•11 years ago
|
||
This is even more true in Gaia apps where the toolbox is on the side (narrow UI) and where there are long attributes with data urls.
Two examples:
- we see the bottom of a very long attribute. We click on it, the markup view scrolls up.
- we only see the end of a line, we click on an attribute to edit it, the markup view scrolls left.
In these 2 examples, the user wants to select something, and once selected, the newly selected element disappears due to the scroll.
Reporter | ||
Updated•11 years ago
|
Blocks: gaia-devtools
Reporter | ||
Comment 3•11 years ago
|
||
I won't be working on that anytime soon. But I'd be very happy if someone could take over :)
Assignee: paul → nobody
Comment 4•11 years ago
|
||
I bet this is the same thing I was seeing on point 3 in this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=931191#c4. It is quite dramatic if you open up a large inplace editor (seems to scroll everything out of view). I agree that we should remove any scolling that happens as a result of clicking a node.
Updated•11 years ago
|
Blocks: DevToolsPaperCuts
Updated•11 years ago
|
Priority: -- → P2
Hardware: x86 → All
Comment 5•10 years ago
|
||
I don't think this is an issue anymore when switching nodes with the mouse, but there is code and a comment that indicates that maybe it should still be? http://dxr.mozilla.org/mozilla-central/source/browser/devtools/markupview/markup-view.js#724-725
Reporter | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•