Heavyweight function inlining is currently disabled because the callee of inlined frames may get lost if it's not a constant (which happens for heavweight + cloned inlined functions). This requires keeping the callee alive until after the inlined function's IR graph. It should be possible to just add a dummy KeepAlive instruction to the return-block of the inlined function, that is otherwise a no-op.. which keeps the callee value alive.

This triggered this build warning in every .cpp file that #includes MIR.h: { Warning: -Woverloaded-virtual in /mozilla-central/js/src/ion/MIR.h: by 'bool js::ion::MForceUse::congruentTo(js::ion::MDefinition* const&) const' /mozilla-central/js/src/ion/MIR.h:1015:10: warning: by 'bool js::ion::MForceUse::congruentTo(js::ion::MDefinition* const&) const' [-Woverloaded-virtual] bool congruentTo(MDefinition * const &ins) const { ^ }

Sorry, I missed the first part: { js/src/ion/MIR.h:371:18: warning: 'virtual bool js::ion::MDefinition::congruentTo(js::ion::MDefinition*) const' was hidden [-Woverloaded-virtual] } Looks like the type of the function arg is not quite right.

This fixes the one mismatched function signature, and fixes the warning on my system.

Comment on attachment 784190 [details] [diff] [review] followup Review of attachment 784190 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for identifying and taking care of that!

Comment on attachment 784190 [details] [diff] [review] followup Review of attachment 784190 [details] [diff] [review]: ----------------------------------------------------------------- Canceling review on this. bbouvier also made this exact same patch, on a dedicated bug (bug 900308), and I r+-ed that instead. Seems more appropriate to push in that bug and close it. Sorry for the confusion!

No worries -- glad it's getting fixed!

Looks like a typo in LIRGenerator::visitForceUse(MForceUse *ins): if (!useBox(lir, 0, ins->input())); <<< semicolon? return false;

(In reply to Douglas Crosher [:dougc] from comment #11) > Looks like a typo in LIRGenerator::visitForceUse(MForceUse *ins): > > if (!useBox(lir, 0, ins->input())); <<< semicolon? > return false; Yeah, that's a rookie mistake :( Jonco has a patch for it I'm r+-ing.