Seems to pass layout/reftests/canvas, no try push because try is closed.

Comment on attachment 783923 [details] [diff] [review] Rename the old CanvasClient classes Review of attachment 783923 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/CanvasClient.h @@ +63,5 @@ > } > > virtual void Update(gfx::IntSize aSize, ClientCanvasLayer* aLayer); > + virtual void Updated() MOZ_OVERRIDE; > + nit: trailing spaces

Comment on attachment 783925 [details] [diff] [review] Create new CanvasClient2D that uses new textures Review of attachment 783925 [details] [diff] [review]: ----------------------------------------------------------------- After our discussion on irc I am expecting another version of this patch which fixes the potential race condition. ::: gfx/layers/client/CanvasClient.cpp @@ +61,5 @@ > + > + if (!mBuffer->Lock(OPEN_READ_WRITE)) { > + return; > + } > + nit: trailing spaces @@ +66,5 @@ > + nsRefPtr<gfxASurface> surface = mBuffer->AsTextureClientSurface()->GetAsSurface(); > + if (surface) { > + aLayer->UpdateSurface(surface); > + } > + nit: trailing spaces ::: gfx/layers/client/CanvasClient.h @@ +63,5 @@ > + TextureInfo GetTextureInfo() const > + { > + return TextureInfo(COMPOSITABLE_IMAGE); > + } > + nit:trailing space ::: gfx/layers/client/TextureClient.h @@ +202,5 @@ > > virtual TextureClientSurface* AsTextureClientSurface() MOZ_OVERRIDE { return this; } > > virtual bool UpdateSurface(gfxASurface* aSurface) MOZ_OVERRIDE; > + nit: trailing spaces

Comment on attachment 783925 [details] [diff] [review] Create new CanvasClient2D that uses new textures Can we just take this as is, and I'll fix the race for both Canvas and Images with a single patch in the other bug.

Comment on attachment 783925 [details] [diff] [review] Create new CanvasClient2D that uses new textures Review of attachment 783925 [details] [diff] [review]: ----------------------------------------------------------------- Ok, please remove the trailing spaces before landing

https://hg.mozilla.org/integration/mozilla-inbound/rev/67c3e4204e44 https://hg.mozilla.org/integration/mozilla-inbound/rev/b8db58f5e209 https://tbpl.mozilla.org/?tree=Try&rev=f6a2f562512f

Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/5695cebb5c12 for breaking the builds like this: https://tbpl.mozilla.org/php/getParsedLog.php?id=26106235&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/a525086d0bf2 https://hg.mozilla.org/integration/mozilla-inbound/rev/760e66b2908e

https://hg.mozilla.org/mozilla-central/rev/a525086d0bf2 https://hg.mozilla.org/mozilla-central/rev/760e66b2908e