Open
Bug 893812
Opened 11 years ago
Updated 2 years ago
tweak document shutdown order
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
NEW
People
(Reporter: surkov, Unassigned)
Details
Attachments
(2 obsolete files)
a follow up from bug 862863.
The need of the patch was to make document logging correct at shutdown stage. It get rids addref/release works what I find nice while Trev has concerns. Pulling the patch here to not get it lost.
Attachment #775660 -
Flags: review?(trev.saunders)
Comment 1•11 years ago
|
||
> stage. It get rids addref/release works what I find nice while Trev has
if you just want to get rid of AddRef / Release that why not just .swap() the mDocumentNode to kfg?
Comment 2•11 years ago
|
||
Comment on attachment 775660 [details] [diff] [review]
patch
so the thing is crazy things can happen when you shutdown an accessible esp a document (that crazy atk stuff that fires sync events), so I'd really rather not have accessibles pint at stuff longer than they have to here.
Actually there's another issue which is that when you remove the DocAccessible from cache of documents it could get deleted in which case you'll write null to freed memory.
Attachment #775660 -
Flags: review?(trev.saunders) → review-
Reporter | ||
Comment 3•11 years ago
|
||
ok, doing a swap kunfuDethGreep and moving it to where we null out mPresShell is ok?
Comment 4•11 years ago
|
||
(In reply to alexander :surkov from comment #3)
> ok, doing a swap kunfuDethGreep and moving it to where we null out
> mPresShell is ok?
I kind of think nulling out mPresShell should maybe happen before the parent->RemoveChild() because of that weird atk stuff, but that's sort of a different issue so I guess its fine.
Reporter | ||
Comment 5•11 years ago
|
||
Assignee: nobody → surkov.alexander
Attachment #780519 -
Flags: review?(trev.saunders)
Reporter | ||
Updated•11 years ago
|
Attachment #775660 -
Attachment is obsolete: true
Reporter | ||
Updated•11 years ago
|
Attachment #780519 -
Attachment is obsolete: true
Attachment #780519 -
Flags: review?(trev.saunders)
Comment hidden (off-topic) |
Comment 7•2 years ago
|
||
Sorry, there was a problem with the detection of inactive users. I'm reverting the change.
Assignee: nobody → surkov.alexander
Updated•2 years ago
|
Severity: normal → S3
Comment 8•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: surkov.alexander → nobody
You need to log in
before you can comment on or make changes to this bug.
Description
•