Closed
Bug 893858
Opened 11 years ago
Closed 11 years ago
More testing for CPOWs
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
(Whiteboard: [e10s] )
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
I wrote some test with a CPOW that is supposed to always throw. Found some bugs on the way and fixed them.
Attachment #775705 -
Flags: review?(dvander)
Updated•11 years ago
|
Attachment #775705 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 1•11 years ago
|
||
I want to add a few more tests here. http://hg.mozilla.org/integration/mozilla-inbound/rev/ca8afb897e13
Whiteboard: [e10s] → [e10s] [leave open]
Comment 2•11 years ago
|
||
Something in this push was causing Linux debug mochitest-other to be perma-crashing. I couldn't find you on IRC, so I had to back the entire push out. https://hg.mozilla.org/integration/mozilla-inbound/rev/998c273658b8 https://tbpl.mozilla.org/php/getParsedLog.php?id=25380532&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=25380601&tree=Mozilla-Inbound
Assignee | ||
Comment 3•11 years ago
|
||
Oh damn. I didn't realize that this is a crash, it looked like some kind of warning on try.
Assignee | ||
Comment 4•11 years ago
|
||
Running to try as well.
Attachment #775705 -
Attachment is obsolete: true
Attachment #777319 -
Flags: review?(dvander)
Updated•11 years ago
|
Attachment #777319 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9e868e45492
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b9e868e45492
Flags: in-testsuite+
Assignee | ||
Comment 7•11 years ago
|
||
I found an other issue, we should not return NULL from className.
Blocks: core-e10s
Assignee | ||
Updated•11 years ago
|
Assignee: general → evilpies
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 years ago
|
Whiteboard: [e10s] [leave open] → [e10s]
Assignee | ||
Comment 8•11 years ago
|
||
I don't really have anything anymore to add after all.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•