Closed
Bug 894597
Opened 11 years ago
Closed 11 years ago
TaskThrottler::TaskComplete shouldn't call nsTArray::RemoveElementAt(0) on an empty array
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
DUPLICATE
of bug 895722
mozilla25
People
(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ajones
:
review+
|
Details | Diff | Splinter Review |
My B2G trunk build is crashing sometimes when I load a bunch of apps and then kill them with
$ adb shell kill -9 $(adb shell b2g-info -c)
I think this is because TaskThrottler::TaskComplete calls nsTArray::RemoveElementAt(0) on an empty nsTArray.
I'll attach a patch which naively puts a guard in place, but I have no idea if this is right.
|
Assignee | |
Comment 1•11 years ago
|
||
This blocks bug 893012 because it's keeping me from being able to test it. I'd guess that this bug probably is not present on b2g18, since we just refactored layers.
Blocks: 893012
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #776666 -
Flags: review?
|
|
Assignee | |
Updated•11 years ago
|
Attachment #776666 -
Flags: review? → review?(ajones)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 776666 [details] [diff] [review]
Patch, v1
Review of attachment 776666 [details] [diff] [review]:
-----------------------------------------------------------------
Happy to see this landed. It will be superseded by bug 888084 otherwise.
Attachment #776666 -
Flags: review?(ajones) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → justin.lebar+bug
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
|
||
Comment 6•11 years ago
|
||
Justin, it looks like you landed an empty changeset.
Status: RESOLVED → REOPENED
Flags: needinfo?(justin.lebar+bug)
Resolution: FIXED → ---
|
|
Assignee | |
Comment 8•11 years ago
|
||
The code now does
if (mMaxDurations > 0) {
if (mDurations.Length() >= mMaxDurations) {
mDurations.RemoveElementAt(0);
}
mDurations.AppendElement(aTimeStamp - mStartTime);
}
so we're good.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•