Closed Bug 894606 Opened 11 years ago Closed 11 years ago

Build bustage after bug 870406

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dholbert, Unassigned)

References

Details

Attachments

(1 file)

I'm hitting build bustage in widget/gtk2 after bug 888863's patch landed. Here's a snippet of my build output, from a clobber mozilla-inbound build: { /mozilla-inbound/widget/gtk2/gtk3drawing.c:75:1: error: unknown type name 'GtkStateFlags' GetStateFlagsFromGtkWidgetState(GtkWidgetState* state) ^ /mozilla-inbound/widget/gtk2/gtk3drawing.c: In function 'GetStateFlagsFromGtkWidgetState': /mozilla-inbound/widget/gtk2/gtk3drawing.c:77:5: error: unknown type name 'GtkStateFlags' GtkStateFlags stateFlags = GTK_STATE_FLAG_NORMAL; ^ /mozilla-inbound/widget/gtk2/gtk3drawing.c:77:32: error: 'GTK_STATE_FLAG_NORMAL' undeclared (first use in this function) GtkStateFlags stateFlags = GTK_STATE_FLAG_NORMAL; ^ /mozilla-inbound/widget/gtk2/gtk3drawing.c:77:32: note: each undeclared identifier is reported only once for each function it appears in /mozilla-inbound/widget/gtk2/gtk3drawing.c:80:22: error: 'GTK_STATE_FLAG_INSENSITIVE' undeclared (first use in this function) stateFlags = GTK_STATE_FLAG_INSENSITIVE; ^ /mozilla-inbound/widget/gtk2/gtk3drawing.c:83:27: error: 'GTK_STATE_FLAG_ACTIVE' undeclared (first use in this function) stateFlags |= GTK_STATE_FLAG_ACTIVE; ^ /mozilla-inbound/widget/gtk2/gtk3drawing.c:85:27: error: 'GTK_STATE_FLAG_PRELIGHT' undeclared (first use in this function) stateFlags |= GTK_STATE_FLAG_PRELIGHT; ^ /mozilla-inbound/widget/gtk2/gtk3drawing.c:87:27: error: 'GTK_STATE_FLAG_FOCUSED' undeclared (first use in this function) stateFlags |= GTK_STATE_FLAG_FOCUSED; ^ /mozilla-inbound/widget/gtk2/gtk3drawing.c: In function 'moz_gtk_button_paint': /mozilla-inbound/widget/gtk2/gtk3drawing.c:872:5: error: unknown type name 'GtkStateFlags' GtkStateFlags state_flags = GetStateFlagsFromGtkWidgetState(state); ^ /mozilla-inbound/widget/gtk2/gtk3drawing.c:873:5: error: unknown type name 'GtkStyleContext' GtkStyleContext* style = gtk_widget_get_style_context(widget); ^ /mozilla-inbound/widget/gtk2/gtk3drawing.c:873:5: warning: implicit declaration of function 'gtk_widget_get_style_context' [-Wimplicit-function-declaration] /mozilla-inbound/widget/gtk2/gtk3drawing.c:873:30: warning: initialization makes pointer from integer without a cast [enabled by default] GtkStyleContext* style = gtk_widget_get_style_context(widget); ^ } I'll post the full log as an attachment. stransky/karl, any idea what's going on? Am I missing a library, maybe? (I do have "libgtk-3-dev" already installed.) I'm on Ubuntu 13.04 64-bit.
Attached file full log of build errors (deleted) —
Here's the full log of the build errors I get, when compiling in widget/gtk2.
(I haven't 100% verified that bug 888863 caused this; I'm just going off of "who touched gtk3drawing.c last".)
Yup, looks like I was just unlucky enough to hit build bustage from bug 870406, actually -- this wasn't caused by bug 888863 after all. RyanVM just backed out bug 870406, so this should now be FIXED by backout.
Blocks: 870406
No longer blocks: 888863
Status: NEW → RESOLVED
Closed: 11 years ago
Component: Widget: Gtk → Build Config
Resolution: --- → FIXED
Summary: Build bustage after bug 888863 ("entry combo box update" for gtk3) → Build bustage after bug 870406
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: