Closed
Bug 894698
Opened 11 years ago
Closed 11 years ago
[FIG] Tablet layout for reading list page
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 888905
People
(Reporter: shilpanbhagat, Assigned: shilpanbhagat)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
sriram
:
feedback-
|
Details | Diff | Splinter Review |
Change reading list page for tablets based on the design: http://cl.ly/image/3S3H1J1S3x0D/o
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → sbhagat
|
|
Assignee | |
Comment 1•11 years ago
|
||
First trial patch for this layout. I would eventually want to replace with HomeListView with HomeGridView. It would keep the layout the same but make it easier to adapt to a more tablet friendly view. Feedback on that? To replace the divider we can give a custom lower border to each cell.
Attachment #776796 -
Flags: feedback?(sriram)
|
||
Updated•11 years ago
|
Blocks: new-about-home
Priority: -- → P1
|
||
Comment 2•11 years ago
|
||
Comment on attachment 776796 [details] [diff] [review]
[WIP] Changing layout for tablet page
I find this to be a roundabout way. Why not just use a GridView in a separate XML for tablets? And since GridView and ListView extend from AbsListView, the java code can use a generic AbsListView and call methods on it. That is simpler and straightforward.
Attachment #776796 -
Flags: feedback?(sriram) → feedback-
|
|
||
Comment 3•11 years ago
|
||
This has been implemented in bug 888905. Closing.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•