Closed Bug 895027 Opened 11 years ago Closed 11 years ago

Various static rooting analysis fixes

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(5 files)

Switch to more accurate set of functions that indicate a GC call for static rooting analysis
(deleted), patch
terrence
: review+
Details | Diff | Splinter Review
Print out commands executed to make it easier to debug individual scripts.
(deleted), patch
Details | Diff | Splinter Review
Use loadRelativeToScript to load helper .js files in static rooting analysis.
(deleted), patch
Details | Diff | Splinter Review
Add a --source argument to analyze.py to make it easier to run from arbitrary directories.
(deleted), patch
Details | Diff | Splinter Review
s/arguments/scriptArgs/.
(deleted), patch
Details | Diff | Splinter Review
The code in the tree has bitrotted with JS engine changes. (I've been using an old checkout for doing the analysis.)
Use Collect() and MinorGC() to determine whether something was a GC. Oh, shoot, wasn't there a bug open for this already? Ugh.
Attachment #777256 - Flags: review?(jcoppeard)
Because, deep down, I am really a bad person, I intend to land this patch and all following without review.
Attached patch s/arguments/scriptArgs/. (deleted) — — Splinter Review
Comment on attachment 777256 [details] [diff] [review] Switch to more accurate set of functions that indicate a GC call for static rooting analysis Review of attachment 777256 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #777256 - Flags: review?(jcoppeard) → review+
Blocks: 829243
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: