Closed
Bug 89504
Opened 24 years ago
Closed 23 years ago
enabling/disabling quicklaunch should not require a restart
Categories
(SeaMonkey :: UI Design, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.4
People
(Reporter: jruderman, Assigned: dead)
References
Details
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Enabling or disabling Quick Launch should not require a restart of the operating
system or the browser.
Steps to reproduce:
1. Enable Quick Launch in Edit->Prefs->Advanced.
2. Close and restart Mozilla.
Result: Mozilla takes a long time to start up.
Expected: Mozilla should restart quickly.
3. Close and restart Mozilla again.
Result: Mozilla takes a long time to start up.
Expected: Mozilla should restart quickly.
4. Close Mozilla.
5. Restart Windows, or run mozilla.exe -turbo.
6. Restart Mozilla.
Result: Mozilla restarts quickly (good).
(Similar steps for trying to disable Quick Launch)
Comment 1•24 years ago
|
||
turbo/quicklaunch ->vishy, qa: paw/jrgm. bill is on sabbatical...
Assignee: law → vishy
QA Contact: sairuh → paw
nav triage team:
marking nsbeta1+, p2, and mozilla1.0
Comment 4•23 years ago
|
||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Comment 5•23 years ago
|
||
r=ccarlen
Comment 10•23 years ago
|
||
Blake - have we tested all the cases with this bug, if so we shd get it sr'ed
and speed it into the tree...
Comment 11•23 years ago
|
||
Conrad is working out an issue with his multiple profiles patch; plan is to land
this after he lands to help avoid conflicts.
Comment 12•23 years ago
|
||
In your code you have (long exprs replaced):
rv = GetNativeAppSupport(getter_AddRefs(nativeApp));
- if (NS_SUCCEEDED(rv) && NS_SUCCEEDED(goats) && moreGoats) {
- // Create special Nav window.
- nativeApp->StartServerMode();
- return NS_OK;
- }
+ // Create special Nav window.
+ if (NS_SUCCEEDED(goats) && moreGoats) {
What is the relevance now of obtaining the return value in:
rv = GetNativeAppSupport(getter_AddRefs(nativeApp));
if the return value is now never used? I'd say it'd allow you to return the
return value with |return rv| at the end of the function, however subsequent
functions promptly clobber whatever value GetNativeAppSupport returned so it's
not really achieving anything ;)
Comment 13•23 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 14•23 years ago
|
||
Paul: please, like, test the crap out of this :-) You may want to wait until
multiple profile support lands. We need to see how changing this pref in one
profile affects the other profiles (we think it's going to be global, and are
okay with that). It's also critical to see how backwards compatible this is,
i.e. what happens if you used turbo in 6.1 and then upgrade. I believe we still
need an installer-side fix to make all this work properly.
Comment 16•23 years ago
|
||
Comment 17•23 years ago
|
||
alright. sr=ben@netscape.com
Comment 18•23 years ago
|
||
Back to having only one attribute for determining whether we're in server mode
is much better. Some of my code (multiple profile patch) was already tripped up
by the difference. r=ccarlen
Comment 19•23 years ago
|
||
Fixed.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Comment 20•23 years ago
|
||
Terri, can you verify this bug for me. I'm up to my ears in reviews. Thanks.
QA Contact: paw → tpreston
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•