Closed
Bug 895083
Opened 11 years ago
Closed 11 years ago
Win64 builds fail because we only have __fastcall
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: ehsan.akhgari, Assigned: glandium)
References
Details
Attachments
(2 files, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
e:\builds\moz2_slave\date-w64-000000000000000000000\build\xpcom\glue\nsThreadUtils.h(330) : error C2953: 'nsRunnableMethodTraits<R(__cdecl C::* )(void),Owning>' : class template has already been defined
e:\builds\moz2_slave\date-w64-000000000000000000000\build\xpcom\glue\nsThreadUtils.h(330) : error C2953: 'nsRunnableMethodTraits<R(__cdecl C::* )(void),Owning>' : class template has already been defined
https://tbpl.mozilla.org/?tree=Date&rev=604c8518cc50
Reporter | ||
Comment 1•11 years ago
|
||
Before: https://tbpl.mozilla.org/?tree=Try&rev=a39733995537
After: https://tbpl.mozilla.org/?tree=Try&rev=c6108d96f25f
Attachment #777352 -
Flags: review?(vladimir)
Comment 2•11 years ago
|
||
Wouldn't it make more sense to wrap the #defined NS_HAVE_STDCALL in an ifndef WIN64 block so that people don't run into this again?
Comment on attachment 777352 [details] [diff] [review]
Patch (v1)
Looks fine, though I also like just not defining NS_HAVE_STDCALL as Neil suggests. (This is literally the only use of NS_HAVE_STDCALL in the tree.)
Attachment #777352 -
Flags: review?(vladimir) → review+
Reporter | ||
Comment 4•11 years ago
|
||
That feels a bit wrong to me, since the __stdcall keyword is still there, it's just ignored by the compiler for codegen and template resolution. But the argument that this will recur in the future is probably correct. I guess I'll do that then.
Reporter | ||
Comment 5•11 years ago
|
||
Attachment #777352 -
Attachment is obsolete: true
Reporter | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
Thanks ehsan
Assignee | ||
Comment 7•11 years ago
|
||
If WIN64 ignores __stdcall, why keep NS_STDCALL non-empty on WIN64?
Assignee | ||
Comment 8•11 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #7)
> If WIN64 ignores __stdcall, why keep NS_STDCALL non-empty on WIN64?
At least it wouldn't feel weird to have NS_STDCALL saying one thing and NS_HAVE_STDCALL saying another.
Comment 9•11 years ago
|
||
Keywords: checkin-needed
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Assignee | ||
Updated•11 years ago
|
Assignee: ehsan → mh+mozilla
Reporter | ||
Updated•11 years ago
|
Attachment #778208 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 12•11 years ago
|
||
Comment 13•11 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•