Closed Bug 895083 Opened 11 years ago Closed 11 years ago

Win64 builds fail because we only have __fastcall

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: ehsan.akhgari, Assigned: glandium)

References

Details

Attachments

(2 files, 1 obsolete file)

e:\builds\moz2_slave\date-w64-000000000000000000000\build\xpcom\glue\nsThreadUtils.h(330) : error C2953: 'nsRunnableMethodTraits<R(__cdecl C::* )(void),Owning>' : class template has already been defined e:\builds\moz2_slave\date-w64-000000000000000000000\build\xpcom\glue\nsThreadUtils.h(330) : error C2953: 'nsRunnableMethodTraits<R(__cdecl C::* )(void),Owning>' : class template has already been defined https://tbpl.mozilla.org/?tree=Date&rev=604c8518cc50
Blocks: 880004
Wouldn't it make more sense to wrap the #defined NS_HAVE_STDCALL in an ifndef WIN64 block so that people don't run into this again?
Comment on attachment 777352 [details] [diff] [review] Patch (v1) Looks fine, though I also like just not defining NS_HAVE_STDCALL as Neil suggests. (This is literally the only use of NS_HAVE_STDCALL in the tree.)
Attachment #777352 - Flags: review?(vladimir) → review+
That feels a bit wrong to me, since the __stdcall keyword is still there, it's just ignored by the compiler for codegen and template resolution. But the argument that this will recur in the future is probably correct. I guess I'll do that then.
Attached patch For check-in (deleted) — Splinter Review
Attachment #777352 - Attachment is obsolete: true
Keywords: checkin-needed
Blocks: 838803
Thanks ehsan
If WIN64 ignores __stdcall, why keep NS_STDCALL non-empty on WIN64?
(In reply to Mike Hommey [:glandium] from comment #7) > If WIN64 ignores __stdcall, why keep NS_STDCALL non-empty on WIN64? At least it wouldn't feel weird to have NS_STDCALL saying one thing and NS_HAVE_STDCALL saying another.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
cf. comment 7 and 8.
Attachment #778208 - Flags: review?(ehsan)
Assignee: ehsan → mh+mozilla
Attachment #778208 - Flags: review?(ehsan) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: