We shouldn't rely on individual developers setting --disable-crashreporter on their build. The build system should do it itself.

Any place that sets --disable-crashreporter after including mozconfig.common will properly use --disable-crashreporter.

Comment on attachment 777591 [details] [diff] [review] Disable crash reporter when cross building across different OSes (e.g. OSX android builds) Review of attachment 777591 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/mozconfig.common @@ +11,5 @@ > # of this file. > > mk_add_options AUTOCLOBBER=1 > + > +ac_add_options --enable-crashreporter I don't understand why you need this.

Comment on attachment 777591 [details] [diff] [review] Disable crash reporter when cross building across different OSes (e.g. OSX android builds) (In reply to Ted Mielczarek [:ted.mielczarek] from comment #2) > > +ac_add_options --enable-crashreporter > > I don't understand why you need this. To avoid having the crash reporter unknowingly disabled for some reason.

Comment on attachment 777591 [details] [diff] [review] Disable crash reporter when cross building across different OSes (e.g. OSX android builds) Review of attachment 777591 [details] [diff] [review]: ----------------------------------------------------------------- I still don't really understand. Are you worried that we'll accidentally start building in some cross-compile configuration which disables crashreporting? I'm not morally opposed to it, it just seems wrong to have to specify something that's actually a default.

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4) > I still don't really understand. Are you worried that we'll accidentally > start building in some cross-compile configuration which disables > crashreporting? Or someone rearranges configure.in and adds a bug, or whatever.