Closed
Bug 895403
Opened 11 years ago
Closed 11 years ago
Disable methods of nsIDownloadManager that are replaced by the JavaScript API
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
Attachments
(1 file)
(deleted),
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
Methods of nsIDownloadManager that have a replacement in the JavaScript API
for downloads should output an error to the Console, but only for products in
which the JavaScript API is actually enabled.
Assignee | ||
Comment 1•11 years ago
|
||
Actually, we should disable the old methods to ensure that the database is never
opened, something like NS_ENSURE_STATE(!mUseJSDownloads).
Summary: Add a deprecation warning to methods of nsIDownloadManager that are replaced by the JavaScript API → Disable methods of nsIDownloadManager that are replaced by the JavaScript API
Comment 2•11 years ago
|
||
It looks like the database is initialized simply by getting the old download manager, not by calling any of its methods. So disabling the methods wouldn't prevent the database from being opened.
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Neil Deakin from comment #2)
> It looks like the database is initialized simply by getting the old download
> manager, not by calling any of its methods. So disabling the methods
> wouldn't prevent the database from being opened.
Yes, we should return early in the Init method if the preference is enabled,
and fail any methods that need to access the database.
Assignee | ||
Comment 4•11 years ago
|
||
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #790108 -
Flags: review?(enndeakin)
Updated•11 years ago
|
Attachment #790108 -
Flags: review?(enndeakin) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•