Closed
Bug 895669
Opened 11 years ago
Closed 11 years ago
Change - override about:addons to display a metro custom page
Categories
(Firefox for Metro Graveyard :: Browser, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 25
People
(Reporter: ally, Assigned: ally)
References
Details
(Whiteboard: feature=change c=tbd u=tbd p=5)
Attachments
(4 files, 4 obsolete files)
(deleted),
patch
|
sfoster
:
review+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
image/png
|
Details |
Since we are not allowing addons in v1, we should disable the ability to access about:addons, as the current about:addons looks very functional and gives no indication that metro addons are not supported.
Updated•11 years ago
|
Blocks: metrov1defect&change
Summary: disable access to about:addons → Change - Disable access to about:addons
Whiteboard: feature=change c=tbd u=tbd p=0
Updated•11 years ago
|
Priority: -- → P1
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ally
Assignee | ||
Comment 1•11 years ago
|
||
Updated•11 years ago
|
Status: NEW → ASSIGNED
QA Contact: jbecerra
Whiteboard: feature=change c=tbd u=tbd p=0 → feature=change c=tbd u=tbd p=5
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → NEW
Summary: Change - Disable access to about:addons → Change - override about:addons to disable a metro custom page
Assignee | ||
Comment 2•11 years ago
|
||
as discussed on irc with mfinkle & yuan, the plan is now to override extensions.xul to display a custom page with a cute image and short, localizable message indicated that addons are not currently supported.
Updated•11 years ago
|
Status: NEW → ASSIGNED
Updated•11 years ago
|
Assignee | ||
Comment 3•11 years ago
|
||
it seems like it can't find the css file.
also the new files have icky windows line endings.
Assignee | ||
Updated•11 years ago
|
Summary: Change - override about:addons to disable a metro custom page → Change - override about:addons to display a metro custom page
Assignee | ||
Comment 4•11 years ago
|
||
Attachment #780067 -
Attachment is obsolete: true
Attachment #783390 -
Attachment is obsolete: true
Attachment #784542 -
Flags: review?(sfoster)
Assignee | ||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Comment on attachment 784542 [details] [diff] [review]
metroaboutaddons
Review of attachment 784542 [details] [diff] [review]:
-----------------------------------------------------------------
Sweet!
Just this thought for snapped-view (which I know we already determined was low priority)
::: browser/metro/theme/aboutAddons.css
@@ +2,5 @@
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +html, body {
> + height: 100%;
If you add:
padding: 0;
margin: 0;
..here you'll get edge-edge color which I think you want.
@@ +28,5 @@
> + text-align: left;
> + word-wrap: normal;
> +}
> +
> +#fox {
nit: trailing whitespace
@@ +36,5 @@
> + background-position: bottom center;
> + background-repeat: no-repeat, repeat-x;
> + background-color: rgb(230, 230, 230); /*color hand sampled from image*/
> +
> +}
You add something simple like the following to get something quite usable for snapped-view:
/* Snapped-view variation */
@media (max-width: 330px) {
#floatingTextBox {
top: 20%;
left: 5%;
width: 90%;
}
}
Attachment #784542 -
Flags: review?(sfoster) → review+
Assignee | ||
Comment 7•11 years ago
|
||
my thinkpad is rendering large black bars for snapped view still, so I can't actually test the snapped part of that patch yet. Builds are running and it'll be a race to verify
Assignee | ||
Comment 9•11 years ago
|
||
wish bugzilla had a good way to preview the text of the patch so you could doublecheck that the file contains the right version.
Attachment #785207 -
Attachment is obsolete: true
Assignee | ||
Comment 10•11 years ago
|
||
Metro team is now checking in code on fx-team not inbound, and fx-team has been closed for most of today.
Keywords: checkin-needed
Comment 11•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: feature=change c=tbd u=tbd p=5 → feature=change c=tbd u=tbd p=5[fixed-in-fx-team]
Comment 12•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: feature=change c=tbd u=tbd p=5[fixed-in-fx-team] → feature=change c=tbd u=tbd p=5
Target Milestone: --- → Firefox 25
Comment 13•11 years ago
|
||
Please see the attached screenshot. This is how it looks for me the about:addons page, on a Win 8 64bit machine, using the latest Nightly, build ID: 20130819030205, tested for iteration #12.
Is this the expected?
Flags: needinfo?
Comment 15•11 years ago
|
||
Thanks! :)
Marking this VERIFIED, based on comment 13 and comment 14.
Status: RESOLVED → VERIFIED
Comment 16•11 years ago
|
||
Went through the following "Change" for iteration #16 and found some issues. Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-23-03-02-05-mozilla-central/
- Went through the suggestions throughout the thread and ensured everything described was implemented and working
- Went to "about:addons" and ensured that the correct image appeared
- Ensured that "Nightly Start Page" redirects the user to the awesome screen without any issues
- Viewed "about:addons" in full, filled and snap view and ensured that the image is displayed correctly
- Went through the above test cases in both Windows 8 and Windows 8.1
Issues:
Ran into a small issue when going through the change in Windows 8.1. When you view the page in the different views, the text will but cut off at times. In Windows 8, it auto corrects and appears correctly but in 8.1 it stays cut off. Created Bug 930367
You need to log in
before you can comment on or make changes to this bug.
Description
•