Closed Bug 895867 Opened 11 years ago Closed 11 years ago

Implement empty screen state for 'tabs from last time'

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Version:
24 Branch
Platform:
ARM
Android
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 26

People

(Reporter: ibarlow, Assigned: liuche)

References

Details

(Whiteboard: abouthome-hackathon, fixed-fig)

Attachments

(4 files, 1 obsolete file)

mockup of empty states
(deleted), image/png
Details
about_home empty icons.zip
(deleted), application/x-zip-compressed
Details
Part 1: icons and strings
(deleted), patch
sriram
: review+
Details | Diff | Splinter Review
Patch: Display empty screen for last tabs page v2
(deleted), patch
lucasr
: review+
Details | Diff | Splinter Review
i.e. show some helpful message when you have nothing in your history
er, tabs from last time, not history.
Attached image mockup of empty states (deleted) —
Assignee: nobody → liuche
OS: Mac OS X → Android
Hardware: x86 → ARM
Ian, can you attach the images for the background?
Flags: needinfo?(ibarlow)
Attached file about_home empty icons.zip (deleted) —
Icons for all the empty panels on about:home.
Flags: needinfo?(ibarlow)
Status: NEW → ASSIGNED
How would these scale for tablets?
Flags: needinfo?(ibarlow)
Bug 895866 does most of the work for this bug, so this will only need a tiny patch after it's reviewed.
Depends on: 895866
Attached patch Part 1: icons and strings (deleted) — — Splinter Review
Attachment #786670 - Flags: review?(sriram)
Attached file Part 2: set empty view v1 (obsolete) (deleted) —
Unfortunately, bug 902288 regresses tab behavior, so no tabs ever appear in the list.
(In reply to Sriram Ramasubramanian [:sriram] from comment #5) > How would these scale for tablets? Sorry, thought I answered this. Same styling, centered in the middle of the screen.
Flags: needinfo?(ibarlow)
Attachment #786670 - Flags: review?(sriram) → review+
Blocks: 903158
Blocks: 903160
This includes the updated non-flashing code used in the cleanup for MostRecentPage.
Attachment #786671 - Attachment is obsolete: true
Attachment #787929 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 787929 [details] [diff] [review] Patch: Display empty screen for last tabs page v2 Review of attachment 787929 [details] [diff] [review]: ----------------------------------------------------------------- Nice. ::: mobile/android/base/home/LastTabsPage.java @@ +154,5 @@ > + } > + > + // Cursor is empty, so hide the title and set the empty view if it hasn't been set already. > + mTitle.setVisibility(View.GONE); > + mRestoreButton.setVisibility(View.GONE); nit: add empty line here.
Attachment #787929 - Flags: review?(lucasr.at.mozilla) → review+
I assume this patch has got the ibarlow stamp of quality btw :-)
I ok'd another empty state screen in another bug, so if this one follows the same styling I'm good :)
landed on fig: https://hg.mozilla.org/projects/fig/rev/69cbdb6652bc
Whiteboard: abouthome-hackathon → abouthome-hackathon, fixed-fig
https://hg.mozilla.org/mozilla-central/rev/69cbdb6652bc
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: