Closed Bug 895933 Opened 11 years ago Closed 11 years ago

Record in the CC log if it is AllTraces or not

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25
blocking-b2g leo+
Tracking Status
firefox23 --- wontfix
firefox24 --- wontfix
firefox25 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

(Whiteboard: [MemShrink][LeoVB+])

Attachments

(1 file, 1 obsolete file)

It would be nice to have a little comment at the start of the log that indicates if AllTraces is used. This helps when you get a log from somebody to tell if it is AllTraces or not.
Attached patch record if AllTraces is true or not (obsolete) (deleted) — Splinter Review
This also required a minor modification to the CC log parser to ignore lines that start with #.
Assignee: nobody → continuation
Attachment #778526 - Flags: review?(khuey)
Comment on attachment 778526 [details] [diff] [review] record if AllTraces is true or not Review of attachment 778526 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/base/nsCycleCollector.cpp @@ +1465,5 @@ > mOutFile->OpenANSIFileDesc("w", &mStream); > NS_ENSURE_STATE(mStream); > MozillaRegisterDebugFILE(mStream); > > + fprintf(mStream, "# WantAllTraces=%d\n", mWantAllTraces); %s, mWantAllTraces ? "true" : "false" ?
Attachment #778526 - Flags: review?(khuey) → review+
Addressed review comment, carrying forward khuey's r+.
Attachment #778526 - Attachment is obsolete: true
Attachment #778537 - Flags: review+
AllTraces was the only flag where it seemed to make sense to record.
Summary: Record what CC logging options have been used in the log → Record in the CC log if it is AllTraces or not
Blocks: 893012
Whiteboard: [MemShrink]
Zero risk, debugging only, necessary for Leo blocker bug 893012.
blocking-b2g: --- → leo+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Whiteboard: [MemShrink] → [MemShrink][LeoVB+]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: