Closed
Bug 896111
Opened 11 years ago
Closed 11 years ago
ssi_saveState(aUpdateAll) take 62% of loading smugmug
Categories
(Firefox :: Session Restore, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Unassigned)
References
Details
I use smugmug for pictures. In one directory, I have 6000 galleries or so. It takes a very long time to load. Profile, it shows that 62% of the time is in ssi_saveState(aUpdateAll).
Reporter | ||
Comment 2•11 years ago
|
||
gavin, that is a huge change. do you think it's going to make 25?
How about we do something simple. can we bail form ssi_saveStatestop() when the document is still loading?
Comment 3•11 years ago
|
||
Actually, it's probably going to be fixed in bug 867143, expected any day now.
Comment 4•11 years ago
|
||
(In reply to Doug Turner (:dougt) from comment #2)
> How about we do something simple. can we bail form ssi_saveStatestop() when
> the document is still loading?
Sounds like something worth investigating, but could be tricky to get right (balancing responsiveness with avoiding dataloss, e.g. if pages are "loading" a long time while you type in a form you don't want to lose all that data).
Reporter | ||
Comment 5•11 years ago
|
||
why would you be writing into a form while the page is still loading? is that something?
Comment 6•11 years ago
|
||
It depends on which definition of "loading" you're using, so we'd need to pick one carefully. By some definitions some pages continue "loading" well after they're usable by users.
Reporter | ||
Comment 7•11 years ago
|
||
Given Yoric thinks 867143 is going to land soon, I don't think I care about something simple any more.
Comment 8•11 years ago
|
||
Bug 867143 has now landed. Doug, could you check whether this helps out?
Flags: needinfo?(doug.turner)
Reporter | ||
Comment 9•11 years ago
|
||
yup. fixed. Yoric, nice work man.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(doug.turner)
Resolution: --- → FIXED
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•