Closed
Bug 896388
Opened 11 years ago
Closed 11 years ago
Read config.status in dictionary_helper_gen.py
Categories
(Core :: DOM: Events, defect)
Core
DOM: Events
Tracking
()
RESOLVED
INVALID
People
(Reporter: gyeh, Unassigned)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
smaug
:
feedback-
|
Details | Diff | Splinter Review |
|
(deleted),
text/plain
|
Details |
https://bugzilla.mozilla.org/show_bug.cgi?id=842948#c45
Currently, dictionary_helper_gen.py doesn't generate code based on any config and it generates "DictionaryHelper.h" and "DictionaryHelper.cpp" on all platforms.
However, for the case in bug 842948, we'd like to use the generator and hope that some dictionaries are generated only when MOZ_B2G_BT is defined in config.status.
|
Reporter | |
Comment 1•11 years ago
|
||
Hi smaug,
Thinker writes a patch for this bug. Could you help to take a look and give us some feedback? Thanks.
Attachment #779126 -
Flags: feedback?(bugs)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Here's one use case for CONFIG var.
|
||
Comment 3•11 years ago
|
||
Just use a WebIDL dictionary.
|
||
Comment 4•11 years ago
|
||
Yeah, if possible, use WebIDL dictionary.
|
|
||
Comment 5•11 years ago
|
||
(We should try to get rid of dictionary_helper_gen.py, and switch everything to use WebIDL)
|
|
||
Updated•11 years ago
|
Attachment #779126 -
Flags: feedback?(bugs) → feedback-
|
|
Reporter | |
Comment 6•11 years ago
|
||
Ok. Thanks :)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•