Closed Bug 896982 Opened 11 years ago Closed 11 years ago

[Contacts] Design and implement a component to transform mozContacts to VCARD format

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g koi+

People

(Reporter: arcturus, Assigned: sergi)

References

Details

(Whiteboard: [u=commsapps-user c=contacts p=0])

Attachments

(1 file, 1 obsolete file)

New Github PR
(deleted), patch
arcturus
: review+
Details | Diff | Splinter Review
We need to create a component that transforms mozContacts to vcard format. The vcard formats are still to be defined, but could be added lately depending on product needs. Also we could put this component in shared and let other applications like SMS/MMS and email benefit from it.
Assignee: nobody → sergi.mansilla
Whiteboard: [u=commsapps-user c=contacts p=0]
The planned vCard format is 3.0.
Attached patch Github PR (obsolete) (deleted) — — Splinter Review
This function converts a single mozContact into a VCard string.
Attachment #787432 - Flags: review?(francisco.jordano)
Minimun comments on the PR, looking really good! Thanks Sergi!
Comment on attachment 787432 [details] [diff] [review] Github PR Great job!
Attachment #787432 - Flags: review?(francisco.jordano) → review+
Landed in master: https://github.com/mozilla-b2g/gaia/commit/1b3b923534f606c69fce61136aa21849ee8bba6a
Status: NEW → RESOLVED
blocking-b2g: --- → koi?
Closed: 11 years ago
Resolution: --- → FIXED
This was causing Gaia unit test bustage on TBPL as well. https://tbpl.mozilla.org/php/getParsedLog.php?id=26350355&tree=B2g-Inbound
blocking-b2g: koi? → koi+
QA Contact: atsai
Hi Ryan, Are you referring to the strict warnings? I don't see errors or tests not passing regarding this patch.
Flags: needinfo?(ryanvm)
It was the same errors seen in comment 9, just run in a different location.
Flags: needinfo?(ryanvm)
Any news on when we can expect this to land?
Looking at it right now
Attached patch New Github PR (deleted) — — Splinter Review
Attachment #787432 - Attachment is obsolete: true
Attachment #792168 - Flags: review?(francisco.jordano)
Comments on github PR
Blocks: 887534
The last PR adds the bits pointed at by Francisco. All the linting errors were fixed from the previous pass, and my tests pass when testing mozContact2vcard individually or along with the contacts suite, and they pass both in Gecko 18 and latest nightly.
Comment on attachment 792168 [details] [diff] [review] New Github PR All tests passed locally, working fine for me. Thanks Sergi
Attachment #792168 - Flags: review?(francisco.jordano) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/b8c80a322c8f52e05690ecd7afc286342095059e
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: