Closed
Bug 897126
Opened 11 years ago
Closed 11 years ago
[fig] Menu button visibile in editing mode in private browsing mode
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: Margaret, Assigned: sriram)
References
Details
(Whiteboard: abouthome-hackathon, fixed-fig)
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
screenshot
See screenshot.
|
Assignee | |
Comment 1•11 years ago
|
||
I don't like how the menu button is split into two. Should investigate the reason and merge them both into one. But this patch works fine with current code base.
Attachment #780008 -
Flags: review?(margaret.leibovic)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → sriram
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 780008 [details] [diff] [review]
Patch
I'm going to redirect this review to lucasr, since he's more familiar with this code.
Attachment #780008 -
Flags: review?(margaret.leibovic) → review?(lucasr.at.mozilla)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 780008 [details] [diff] [review]
Patch
Review of attachment 780008 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch. Menu button split was added so that we could fade out the tab counter and menu icon but keep the dark gray background behind them when the tabs tray is open.
Attachment #780008 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
We could have done that with an image level on the menu button right?
|
|
||
Comment 5•11 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #4)
> We could have done that with an image level on the menu button right?
How would you go about fading out only the icon while keeping the button's background color using image levels?
|
|
Assignee | |
Comment 6•11 years ago
|
||
The background color is supplied by android:background property. The android:src property can show a LevelDrawable. The current menu level has transparency in it for level 2. To provide a "fade" effect, a TransistionDrawable can be used. That allows switching between two levels with an animation.
|
|
Assignee | |
Comment 7•11 years ago
|
||
Whiteboard: abouthome-hackathon → abouthome-hackathon, fixed-fig
|
|
||
Comment 8•11 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #6)
> The background color is supplied by android:background property. The
> android:src property can show a LevelDrawable. The current menu level has
> transparency in it for level 2. To provide a "fade" effect, a
> TransistionDrawable can be used. That allows switching between two levels
> with an animation.
Not exactly what we want because the fading would have to happen in sync with the tab counter's animation using an AccelerateInterpolator.
|
||
Comment 9•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•