Closed Bug 897395 Opened 11 years ago Closed 7 years ago

Remove setItemIndex and implement reorder on the backend side

Categories

(Toolkit :: Places, defect, P3)

Product:
Toolkit
Component:
Places
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: asaf, Unassigned)

References

(Depends on 1 open bug)

Details

The sort-by-name transaction uses a combination of setItemIndex and runInBatchMode. That's the only use case for setItemIndex, and rightly so because if calling setItemIndex on a single item is error prone (moveItem is the appropriate method for such cases).

I suggest we move sort-by-name to the back-end, and remove setItemIndex, esp. now that runInBatchMode is likely to be removed. I know there are some addons that use setItemIndex in order to implement other sort options, but we can support that by allowing to pass in the sort function.
Depends on: 539517
Depends on: 1069410
Summary: Remove setItemIndex and implement sort-by-name on the bac-kend side → Remove setItemIndex and implement reorder on the backend side
Depends on: 1235054
Priority: -- → P3
we have a new API and we are removing SetItemIndex.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.