Closed Bug 897659 Opened 11 years ago Closed 11 years ago

add support for test specific extensions, cleanup some results

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file)

We have a need for a test specific extension in the new tart test. This is pretty straightforward. While testing the extension, I found some corner cases in the results and added more checking around there.
Blocks: 848358
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #780573 - Flags: review?(jhammel)
Comment on attachment 780573 [details] [diff] [review] test specific extensions, more robust results (1.0) Review of attachment 780573 [details] [diff] [review]: ----------------------------------------------------------------- nice finds! Thanks, Joel! ::: talos/results.py @@ +188,4 @@ > for line in lines: > result = {} > r = line.strip().split(',') > + r = [i for i in r if i != ''] I would do just `if i` vs `if i != ''`; likewise below.
Attachment #780573 - Flags: review?(jhammel) → review+
landed: https://hg.mozilla.org/build/talos/rev/f25ac73076c2 will deploy in the next talos deployment (eta, next week)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: