Closed Bug 897782 Opened 11 years ago Closed 11 years ago

[Bluetooth][Gecko] Support Multiple BT file transfering

Categories

(Firefox OS Graveyard :: Bluetooth, defect, P1)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Type:
defect

Tracking

(blocking-b2g:1.3+, firefox28 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 Sprint 4 - 11/8
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox28 --- fixed

People

(Reporter: sync-1, Assigned: ben.tian)

References

(
URL
)

Details

(Whiteboard: c=)

Attachments

(3 files, 5 obsolete files)

493700.Kernel log&logcat log
(deleted), application/octet-stream
Details
493700.Kernel log& logcat log
(deleted), image/x-png
Details
[final] Patch 1: decouple opp mgr and profile controller, r=echou
(deleted), patch
Details | Diff | Splinter Review
AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.158 Firefox os v1.1 Mozilla build ID:20130709070206 Created an attachment (id=468352) Images DEFECT DESCRIPTION: Can't send files to other BT device while receiving files via bluetooth from a remote device. REPRODUCING PROCEDURES: 1)switch on bluetooth from settings menu->receive files from a remote bluetooth device A; 2)enter gallery/music/video->select a file share via bluetooth; 3)on device select screen->choose a paired device B and press OK->it prompts can't send files message;(refer to attachment pic)-->KO Notes: while receiving finished, it can send files normally without any other operations. EXPECTED BEHAVIOUR: KO:it should can send files to other device normally while receiving files via BT. ASSOCIATE SPECIFICATION: TEST PLAN REFERENCE: TOOLS AND PLATFORMS USED: USER IMPACT: Moderate REPRODUCING RATE: 5/5 For FT PR, Please list reference mobile's behavior:
Clone from brother
Attached file 493700.Kernel log&logcat log (deleted) —
Clone from brother
Attached image 493700.Kernel log& logcat log (deleted) —
Component: Gaia::Bluetooth File Transfer → Bluetooth
Assignee: nobody → echou
blocking-b2g: --- → leo?
This sounds like enhancement/feature work for BT in upcoming versions and not a blocker for v1.1 at this point.
blocking-b2g: leo? → -
Whiteboard: c=
blocking-b2g: - → koi?
I've handed this over to Ben.
Assignee: echou → btian
Current gecko patch that queues SendFile requests in opp manager.
Attached patch Patch 2: Gaia calls SendFile only (obsolete) (deleted) — — Splinter Review
A testing gaia patch that calls SendFile only to transfer files.
Attached patch Patch 1 (v2): Queue SendFile requests (obsolete) (deleted) — — Splinter Review
Remove all BluetoothReply.
Attachment #795953 - Attachment is obsolete: true
Attached patch Patch 1 (v3): Queue SendFile requests (obsolete) (deleted) — — Splinter Review
Add OnConnectError handling that notifies gaia of failed file transfers.
Attachment #796566 - Attachment is obsolete: true
add to backlog 905585 for BT multiple file transfer feature
Blocks: 905585
blocking-b2g: koi? → ---
Blocks: 921085
blocking-b2g: --- → 1.3+
Summary: [Buri][Bluetooth]Can't send files to other BT device while receiving files via bluetooth. → [Bluetooth][Gecko] Support Multiple BT file transfering
Target Milestone: --- → 1.3 Sprint 4 - 11/8
Depends on: 932192
Depends on: 929306
This is a follow-up patch of bug 932192's fix. This patch decouples OPP manager from profile controller. Changes: - Empty Connect, Disconnect, OnConnect, and OnDisconnect functions in OPP manager - Remove OPP part in profile controller
Attachment #795956 - Attachment is obsolete: true
Attachment #797035 - Attachment is obsolete: true
Attachment #826640 - Flags: review?(echou)
Comment on attachment 826640 [details] [diff] [review] Patch 1 (v1): decouple opp mgr and profile controller Review of attachment 826640 [details] [diff] [review]: ----------------------------------------------------------------- r=me with nits addressed. ::: dom/bluetooth/BluetoothOppManager.cpp @@ +1541,5 @@ > void > +BluetoothOppManager::Connect(const nsAString& aDeviceAddress, > + BluetoothProfileController* aController) > +{ > + // No use Please MOZ_ASSERT(false) to detect unexpected calls. @@ +1547,5 @@ > + > +void > +BluetoothOppManager::Disconnect(BluetoothProfileController* aController) > +{ > + // No use Ditto. @@ +1555,3 @@ > BluetoothOppManager::OnConnect(const nsAString& aErrorStr) > { > + // No use Ditto. @@ +1559,5 @@ > > void > BluetoothOppManager::OnDisconnect(const nsAString& aErrorStr) > { > + // No use Ditto.
Attachment #826640 - Flags: review?(echou) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e87c7a3d7de0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: in-moztrap?
URL: https://moztrap.mozilla.org/manage/ca...
Flags: in-moztrap? → in-moztrap+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: