Closed
Bug 897834
Opened 11 years ago
Closed 11 years ago
B2G Emulator: Refactor the fall-through flow for RIL_REQUEST in reference-ril
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file, 1 obsolete file)
The fall-through flow for RIL_REQUEST [1] in reference-ril has some potential problems.
* It is easy to break the flow by changing the sequence and finally run into an unexpected case block.
* Can not base on this flow to have the same check for GSM specific requests.
Maybe we should have a separated switch-case for CDMA/GSM specific request set. It seems more clear and more easily to maintain.
Thanks
[1] https://github.com/mozilla-b2g/platform_hardware_ril/blob/ec665107b24b2002e45d9de5236536130d7b1827/reference-ril/reference-ril.c#L2434
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #780889 -
Flags: review?(vyang)
|
||
Comment 2•11 years ago
|
||
Pointer to Github pull-request
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 782408 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/platform_hardware_ril/pull/21#issuecomment-21698812
oops! Was just browsing accidentally hit the attach button...
Attachment #782408 -
Attachment is obsolete: true
|
||
Comment 4•11 years ago
|
||
Comment on attachment 780889 [details]
hardware/ril pull request #21
nit: TECH_BIT(sMdmInfo) & (MDM_CDMA | MDM_EVDO). Will merge after this nit addressed.
Attachment #780889 -
Flags: review?(vyang) → review+
|
|
||
Comment 5•11 years ago
|
||
Merged on GitHub: https://github.com/mozilla-b2g/platform_hardware_ril/commit/3ee3eba20f763699b3d711839fed972c999daf85
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•