if chat window in Facebook is maximized, it looks awkward. Menu bar is not arranged properly. See attached screenshot.

This is a content issue.

(In reply to Shane Caraveo (:mixedpuppy) from comment #1) > This is a content issue. Are you sure? I don't see how the content could cause the menu bar to be expanded. And by the way, do we really need a menu bar on chat windows?

(In reply to Florian Quèze [:florian] [:flo] from comment #2) > (In reply to Shane Caraveo (:mixedpuppy) from comment #1) > > This is a content issue. > > Are you sure? I wonder if comment 1 was meant for bug 898167.

Yeah, I think this is obviously a social bug rather than a provider issue. I can't repro it at the moment though as FB messenger isn't working correctly, and Shane's demo provider also isn't - I hope this isn't pointing at some broader social issue?

(In reply to Mark Hammond (:markh) from comment #4) > Yeah, I think this is obviously a social bug rather than a provider issue. > I can't repro it at the moment though as FB messenger isn't working > correctly, and Shane's demo provider also isn't - I hope this isn't pointing > at some broader social issue? fb broke with their tuesday update, I've notified them. but my demo provider has been running fine. I obviously made a mistake somewhere, the image is obviously a problem on our end.

This fixes the appearance of the menubar. I tested that it fixes it on Windows, and that it doesn't cause any visible change on Mac. I haven't tested Linux, but as I've just adapted the XUL markup to be closer to browser.xul and not tweaked any CSS, I don't expect any OS-specific issue.

I'm not sure why the menubar was added, but I don't see a strong value for it on Windows/Linux, so the other solution is to have the menu bar only on Mac where it's displayed at the top of the screen.

Comment on attachment 789571 [details] [diff] [review] Fix the menubar This is fine, though I agree, we don't need the menu on win/lin

Comment on attachment 789576 [details] [diff] [review] Have the menu only on Mac lets do this, and lets see how far we can uplift it. maybe if we're unlucky, we can slip it into a point release?

Comment on attachment 789571 [details] [diff] [review] Fix the menubar Both Shane and me prefer attachment 789576 [details] [diff] [review], so I'm marking this one as obsolete.

Comment on attachment 789576 [details] [diff] [review] Have the menu only on Mac [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 880911 User impact if declined: ugly menu bar on Windows and Linux in detached SocialAPI chat windows. Testing completed (on m-c, etc.): Patch currently on m-c. Risk to taking this patch (and alternatives if risky): low. String or IDL/UUID changes made by this patch: none.

Not a regression so no need to track but we'll take the low risk uplift since it's nice and early in the release.

Comment on attachment 789571 [details] [diff] [review] Fix the menubar Seems like we should take this patch too, though? I'm not sure it makes much sense to place the <menubar> at the top level of the document.

(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #15) > Comment on attachment 789571 [details] [diff] [review] > Fix the menubar > > Seems like we should take this patch too, though? I'm not sure it makes much > sense to place the <menubar> at the top level of the document. I can check it in too if you like, but I don't think it makes any difference on Mac where the menu bar is just moved to the top of the screen (and macBrowserOverlay.xul/browserMountPoints.inc seem to include the menubar at the top level).

https://hg.mozilla.org/releases/mozilla-aurora/rev/0eadb85d3eec https://hg.mozilla.org/releases/mozilla-beta/rev/795d74b7380d

Samvedana, can you please verify this is fixed across all versions?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0 Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Firefox/24.0 Mozilla/5.0 (Windows NT 6.2; rv:24.0) Gecko/20100101 Firefox/24.0 Verified as fixed on Firefox 24 beta 6 (buildID: 20130826142034) and latest Nightly (buildID: 20130826190748).

Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20100101 Firefox/25.0 Verified as fixed with latest Aurora 25.0a2 (Build ID: 20130909004001).

Verified as fixed on the latest Aurora 26.0a2 - the detached maximized chat window does not have a menu bar. Verified on Ubuntu 13.04, Windows 8 and Mac 10.8: Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0 Mozilla/5.0 (Windows NT 6.2; rv:26.0) Gecko/20100101 Firefox/26.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Build ID: 20131003004003