Closed
Bug 898281
Opened 11 years ago
Closed 11 years ago
[Dialer] Attention screen when making a call from contact details does not show all the info correctly
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(blocking-b2g:leo+, b2g18 verified)
People
(Reporter: isabelrios, Assigned: rik)
References
Details
(Keywords: regression)
Attachments
(2 files)
Unagi device v1-train 07/26 build:
Gecko-e537445
Gaia-bdc8fb7
ref ril.
STR
1. Create a contact with type: mobile and phone number
2. From contact's details screen tap on the number to start the call
3. Look at the attention screen
EXPECTED
Contact's details are shown fine
ACTUAL
Under the contact name it is shown: ',phone number'
If the user is stored with carrier, then it is shown: ',carrier'
There is nothing ahead of the ','. Please see screenshots attached.
Contact Aa with: mobile type and number
Contact Bb with: mobile type, number and carrier.
This bug may depends on this bug883911.
Marking as leo? as this is a regression.
Reporter | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Vivienne, Can you or can you find someone to check this bug out?
blocking-b2g: leo? → leo+
Flags: needinfo?(21)
Comment 3•11 years ago
|
||
Sorry this should have been directed at Etienne
Flags: needinfo?(21) → needinfo?(etienne)
Assignee | ||
Comment 4•11 years ago
|
||
Wayne: Etienne is on PTO, I'll work on this.
Assignee: nobody → anthony
Flags: needinfo?(etienne)
Assignee | ||
Comment 5•11 years ago
|
||
The type of phone number is missing in this.
In my testing, on v1-train, _('mobile') returns an empty string. But it works on master. I can't find any mobile string in our .properties file.
https://github.com/mozilla-b2g/gaia/blob/4b8a6d1d2aa3f5557b66c9863e397d2946e4e69b/apps/communications/dialer/js/utils.js#L83
Assignee | ||
Comment 6•11 years ago
|
||
First, I'm dumb and we have 'mobile' strings in our .properties, I was just using a bad regexp to grep our codebase.
After some testing, applying bug 853933 on v1-train solves this issue.
Assignee | ||
Comment 7•11 years ago
|
||
And this landed on Friday, working fine now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•11 years ago
|
||
Verified with Unagi device v1-train 08/05 build:
Gecko-8878e8a
Gaia-45f6a73
Ref ril
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
status-b2g18:
--- → fixed
Verified fixed, the issue no longer reproduces.
Environmental Variables
Build ID: 20130814041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/15813d776a69
Gaia: dd3959fa74e356a528daa76ffee14c2c728a4b56
Platform Version: 18.1
Contact's details renders correctly.
You need to log in
before you can comment on or make changes to this bug.
Description
•