BUILD: 2001-07-06-08 The font panel in preferences just has a number for the font size. It's not clear that this number is in pixels, and people will tend to assume that it's in points. On many systems pixels and points are not at all the same size...

Does the user care? Bigger number, bigger font. Smaller number, smaller font. Double the number, double the size of the font. Just what they are used to in any app which needs to let you set font sizes. We could add a "px" at the end of each. But why bother? Who will change their behaviour depending on whether it's points or pixels? Gerv

Yes, some users do care :-) And that's a little something for the competition to catch up... especially remembering that all is already there in situ in the codebase...

Gerv, pt stay the same size on different resolution monitors (assuming one's DPI settings are correct). px do not. I'm using a single Moz profile on multiple computers (shared homedir). It's nice to know at a glance whether my chosen font size will stay constant or whether it'll fluctuate (in the latter case I may pick a larger size, so it's always readable).

*** Bug 90201 has been marked as a duplicate of this bug. ***

OK, I have a patch. But I'd really like someone to explain to me why my text doesn't show up unless I hard-code the column width, which is Bad. CCing some XUL gurus. Surely the entire _point_ is that it sizes everything as best it can to get it all in? Without width="45" the "pixels" text simply isn't rendered... Gerv

You probably want to use flex="x%" instead of width="". So split up the flex by how many percent of the area you want them to take up. That's the most efficent way to use flex, IMHO. Like this: <columns><column flex="50%"/><column flex="50%"></columns> to get two columns using half of the space each.... You get the point.

Well no, not really. I want the column for "pixels" to be exactly as wide as the contained text. I thought the way to do this was to add no instructions at all, and the layout engine would make sure that this happened. But obviously not - it just hides it completely. Adding width="x%" would make it too wide at big window widths and two narrow at small ones. I want _all_ the resizing flex to be in the font name lists. How would you suggest I do the above? Gerv

fixed="true"?

I've never heard of that option, and it has no effect when added to either the <column> or the <text>. Could you be a bit more specific? It's not as if "I want this XUL thingie to be big enough for its content, but no bigger" is an uncommon request... Gerv

How about adding `Typeface' and `Size (pixels)' cells as a header row in the grid, above the columns of popup menus? That way you don't need to repeat `pixels' or `px' half a dozen times.

I'd like to point out that we _do_ have some back end support for sizing in points. There is a pref for the unit that font sizes are in that is supported in some of the code (but not all of it). Therefore, it may make sense to just add: "Font sizes are in px" below the whole grid and later change "px" to a menulist if/when we support choosing the unit the sizes are in. Just throwing out ideas. mpt's suggestion would be plenty fine by me for now....

r=bzbarsky@mit.edu

autostretch is deprecated, replaced with pack & align. hewitt can explain.

This patch fixes this bug, and 96339 - which is a visual problem with the DPI dropdown. It's low risk, so we can do this for 0.9.4. Looking for review - bzbarsky? Gerv

I don't really know how pack works, so I can't review this... Is there a URL explaining it somewhere?

http://www.mozilla.org/projects/xul/layout.html Basically pack and align replace autostretch. There's probably a newsgroup post too... yes, but it just references that page: "align="left|right" is deprecated, as is text-align in CSS. valign is deprecated as is vertical-align in CSS. autostretch is deprecated. The replacement attributes are align (with start/center/end vals) and pack, and the replacement CSS properties are -moz-box-align and -moz-box-pack. See the layout section of the spec for information on how alignment and packing work." Gerv

r=bzbarsky

+ if (item != null) if (item)? sr=blake

Comment on attachment 47337 [details] [diff] [review] Patch v.3 - also fixed bug 96339 a=asa on behalf of drivers (also checking the r= and sr= since I see them in the comments)

Fixed. Gerv

vrfy fixed. linux, 2001.09.04.08-comm winnt, 2001.09.04.00-comm mac 9.1, 2001.09.04.11-comm