Closed Bug 898541 Opened 11 years ago Closed 7 years ago

[Mac HiDPI]: "Thunderbird" text and icon in About window should be HiDPI

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr60 fixed, thunderbird60 fixed, thunderbird61 wontfix, thunderbird62 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 62.0
Tracking Flags:
Tracking Status
thunderbird_esr60 --- fixed
thunderbird60 --- fixed
thunderbird61 --- wontfix
thunderbird62 --- fixed

People

(Reporter: Nomis101, Assigned: Paenglab)

References

Details

Attachments

(2 files)

Screenshot of the issue
(deleted), image/jpeg
Details
Bug898541.patch
(deleted), patch
Fallen
: review+
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review
If you go to the TB About window, the text "Thunderbird" and the TB icon are blurry on a Mac with Retina display because there are not HiDPI
Attached image Screenshot of the issue (deleted) —
Attached patch Bug898541.patch (deleted) — — Splinter Review
This patch uses on official channel for the TB icon and the wordmark a SVG image to be DPI independent. For Daily only the wordmark is a SVG. This because the Daily icon looks also on HiDPI good. And the main reason: we don't have a SVG image for this icon.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8975276 - Flags: review?(philipp)
Comment on attachment 8975276 [details] [diff] [review] Bug898541.patch Review of attachment 8975276 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/branding/thunderbird/content/about-logo.svg @@ +1,3 @@ > +<!-- This Source Code Form is subject to the terms of the Mozilla Public > + - License, v. 2.0. If a copy of the MPL was not distributed with this > + - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> Just checking, is the logo indeed MPL licensed?
Attachment #8975276 - Flags: review?(philipp) → review+
(In reply to Philipp Kewisch [:Fallen] from comment #3) > Comment on attachment 8975276 [details] [diff] [review] > Bug898541.patch > > Review of attachment 8975276 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mail/branding/thunderbird/content/about-logo.svg > @@ +1,3 @@ > > +<!-- This Source Code Form is subject to the terms of the Mozilla Public > > + - License, v. 2.0. If a copy of the MPL was not distributed with this > > + - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> > > Just checking, is the logo indeed MPL licensed? I don't know. FX has the MPL license on the their wordmark, which is a SVG, too. I can remove the boilerplate when you think, it's better.
No, in that case it is fine, I'm assuming the TB wordmark is the same license then. Better to have a license in the file than no license at all.
Thanks.
Keywords: checkin-needed
Comment on attachment 8975276 [details] [diff] [review] Bug898541.patch branding/thunderbird is actually for TB 60. So it makes sense to uplift.
Attachment #8975276 - Flags: approval-comm-esr60?
Attachment #8975276 - Flags: approval-comm-beta?
Attachment #8975276 - Flags: approval-comm-esr60?
Attachment #8975276 - Flags: approval-comm-esr60+
Attachment #8975276 - Flags: approval-comm-beta?
Attachment #8975276 - Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/d6ce9744af9f Make the about dialog HiDPI safe. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 62.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: