Closed Bug 89856 Opened 23 years ago Closed 16 years ago

computed offset left of a colgroup element in a dir=rtl table is wrong

Categories

(Core :: Layout: Tables, defect, P3)

Product:
Core
Component:
Layout: Tables
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: Erich.Iseli, Assigned: bernd_mozilla)

References

(Blocks 1 open bug)

Details

(Keywords: html4, rtl, testcase, Whiteboard: [awd:tbl][HTML4-11.2.4.1][HTML4-11.2.1.1])

Attachments

(3 files, 1 obsolete file)

testcase
(deleted), text/html
Details
testcase
(deleted), text/html
Details
revised patch
(deleted), patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review
Tested with Mozilla 0.9.2 Since Bug 24366 was fixed, we can now care of the following problem: (I will attach a testcase) If the direction of a table is right-to-left, and this table has some colgroup elements defined, the colgroup elements are still considered in the left-to-right order, while the td elements are correctly considered in the right-to-left order.
Attached file testcase (deleted) —
Adding keywords
Keywords: html4, testcase
yeah, that was questions I asked myself also whether we are bidi conformant. nice catch
Is this just a duplicate of bug 915 or is there more to it?
The order of the background color is wrong.
hmm, good testcase! reprod in newest build.
Whiteboard: [awd:tbl]
Temporarily moving to future until a milestone can be assigned.
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Blocks: 137995
Hmm... with build 2002061603 on OSX, I am not getting any background colors in this test case. what is going on?
This testcase freaks out DOM Inspector: it highlights the wrong colgroup when you click on it. The computed style is correct on the colgroups, but the color isn't appearing; maybe that's bug 915.
Whiteboard: [awd:tbl] → [awd:tbl][HTML4-11.2.4.1][HTML4-11.2.1.1]
mass reassign to default owner
Assignee: karnaze → table
Status: ASSIGNED → NEW
QA Contact: amar → madhur
Target Milestone: Future → ---
Priority: -- → P3
Target Milestone: --- → Future
the testcase looks Ok to me but the DOMI really gets something wrong
Assignee: layout.tables → nobody
QA Contact: madhur → layout.tables
Summary: dir=rtl doesn't apply to colgroup element → DOMI Problem with colgroup element in a dir=rtl table
Summary: DOMI Problem with colgroup element in a dir=rtl table → computed offset left of a colgroup element in a dir=rtl table is wrong
Attached file testcase (deleted) —
please notice that all other browser vendor (IE, opera return 0 safari -1) return garbage for offsetLeft on a table
nsTableFrame::SetColumnDimensions is rtl agnostic it should handle it like nsTableRowFrame::ReflowChildren with a nsTableIterator
Attached patch patch (obsolete) (deleted) — — Splinter Review
Assignee: nobody → bernd_mozilla
Status: NEW → ASSIGNED
Attachment #302459 - Flags: superreview?(roc)
Attachment #302459 - Flags: review?(roc)
Simplify this a bit by setting PRInt32 tableDir = ... ? 1 : -1 and then doing colX += tableDir below.
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
Comment on attachment 302459 [details] [diff] [review] patch Need to address comment #16
Attachment #302459 - Attachment is obsolete: true
Attachment #302459 - Flags: superreview?(roc)
Attachment #302459 - Flags: review?(roc)
Attached patch revised patch (deleted) — — Splinter Review
> Need to address comment #16 done
Attachment #332129 - Flags: superreview?
Attachment #332129 - Flags: review?
Attachment #332129 - Flags: superreview?(roc)
Attachment #332129 - Flags: superreview?
Attachment #332129 - Flags: review?(roc)
Attachment #332129 - Flags: review?
Attachment #332129 - Flags: superreview?(roc)
Attachment #332129 - Flags: superreview+
Attachment #332129 - Flags: review?(roc)
Attachment #332129 - Flags: review+
fix checked in
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: