Closed
Bug 898816
Opened 11 years ago
Closed 11 years ago
Leak log file still in use on winxp 32
Categories
(Testing :: XPCShell Harness, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mihneadb, Assigned: mihneadb)
References
Details
There's quite a number of these errors in this [1] log file. I'm not sure why this happens, seems to be a windows-only thing.
[1] https://tbpl.mozilla.org/php/getParsedLog.php?id=25799357&tree=Try&full=1
Comment 1•11 years ago
|
||
Windows is the only OS that has issues with removing files that are still open by a process. If this turns out to be a blocker we can just rip out all the leak logging code from the xpcshell harness. We're not actually using it for anything useful (we don't fail xpcshell tests for leaking), and nobody has been motivated to make that happen, so it's just taking up space.
http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/runxpcshelltests.py#932
and the related bits.
Assignee | ||
Comment 2•11 years ago
|
||
Here's a try run without the leaklog bits. It also contains the other patches, tbpl doesn't show them.
https://tbpl.mozilla.org/?tree=Try&rev=73c453ce4366
Assignee | ||
Comment 3•11 years ago
|
||
Had a bug in that one. https://tbpl.mozilla.org/?tree=Try&rev=b44562a72973
Assignee | ||
Comment 4•11 years ago
|
||
Actually it turns out that the mozcrash patches don't play nice with the current status of the parxpc harness, so here'a a try run without them https://tbpl.mozilla.org/?tree=Try&rev=46cdab537143
Assignee | ||
Comment 5•11 years ago
|
||
It seems that this fixes our problem. I retriggered a few runs to make sure.
Assignee | ||
Comment 6•11 years ago
|
||
As discussed on IRC, will take out the leak log parts in the parxpc patch.
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•