Closed Bug 899046 Opened 11 years ago Closed 11 years ago

Object.getOwnPropertyNames(window) is missing Worker until it is used

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: jruderman, Assigned: khuey)

References

Details

(Keywords: testcase)

Attachments

(1 file)

Attached file testcase (deleted) —
Even with bug 807222 fixed, Object.getOwnPropertyNames(window) is still missing "Worker".

In fact, once I use Worker, several more properties appear:
WorkerEvent,WorkerMessageEvent,WorkerErrorEvent,WorkerProgressEvent
This caused my fuzzer to miss bug 897678.

If these are the only missing properties, I can work around the problem by teaching my fuzzer about Worker.  Are there likely to be others?
Worker implementation is very special, and we must convert it to use normal webidl/non-manual-JSAPI stuff.
Looks like workers are the main special-case here, yeah.

We could probably fix this by doing a ResolveWorkerClasses with the "Worker" id in nsWindowSH::Enumerate.  Seems hacky, but would fix this bug...  Worth doing?
Flags: needinfo?(khuey)
Long-term, will converting Window to WebIDL (bug 789261) take care of this?
Converting workers to webidl should be enough, I believe.

We can hack through it if needed but I'd rather just do that.
Flags: needinfo?(khuey)
Is there a bug for moving workers to WebIDL?  We can make this bug depend on it.
> Long-term, will converting Window to WebIDL (bug 789261) take care of this?

No, but converting Workers to WebIDL will like Kyle says.
Workers have been converted to WebIDL.
Status: NEW → RESOLVED
Closed: 11 years ago
Depends on: 919885
Resolution: --- → FIXED
Assignee: nobody → khuey
Target Milestone: --- → mozilla28
Want to check in the test?
Flags: needinfo?(jruderman)
I don't think this needs its own test now that it just uses the same code as everything else.
Flags: needinfo?(jruderman)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: