Closed Bug 899326 Opened 11 years ago Closed 11 years ago

Recurrences with BYMONTHDAY=X,X,31 don't show at all in months with less than 31 days

Categories

(Calendar :: ICAL.js Integration, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Taraman, Assigned: Taraman)

References

Details

Attachments

(1 file, 2 obsolete files)

User Agent Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20100101 Thunderbird/25.0a1 Lightning 2.7a1 BYMONTHDAY Rule parts which are bigger than the days in month should simplý be skipped. Here, the Whole month gets skipped. Reproducible: Always Steps to Reproduce: 1. create a recurring item with some days including the 31st 2. navigate to a month with less than 31 days. result: In this month none of the occurrences are shown. expected result: The occurrences earlier in the month should be shown.
Severity: critical → major
Blocks: 899770
Attached patch Patch V1 (obsolete) (deleted) — Splinter Review
This is caused by automatic normalization of the "last" date if this.last.date gets set > daysInMonth. In this case, the normalization function will increment the month.
Attachment #785422 - Flags: review?
Attachment #785422 - Flags: review? → review?(jlal)
Attached patch Patch V1.1 (obsolete) (deleted) — Splinter Review
Forgot to include one line in this patch ISO another one.
Attachment #785422 - Attachment is obsolete: true
Attachment #785422 - Flags: review?(jlal)
Attachment #785426 - Flags: review?(jlal)
Comment on attachment 785426 [details] [diff] [review] Patch V1.1 Can you please add/update the tests to add a case for this?
Attachment #785426 - Flags: review?(jlal) → review-
Attached patch Patch V2 (deleted) — Splinter Review
I added a test to test_recur.js. to make the tests run on icaljs, the pref needs to be set and two tests have to be disabled, since they fail. To make this easier, I wrote a small patch [1] which can be found in my mq-patch repo [1]: http://hg.mozilla.org/users/Mozilla_Adrario.de/mq-patches/file/efbad47506ee/enable-icaljs-testing.diff
Attachment #785426 - Attachment is obsolete: true
Attachment #789816 - Flags: review?(jlal)
This bug is fixed upstream in ical.js. The tests will go into calendar with Bug 908745
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 789816 [details] [diff] [review] Patch V2 Landed upstream, removing review request.
Attachment #789816 - Flags: review?(jlal)
Depends on: 932217
Should be fixed by Bug 932217 in Lightning 3.2.
Target Milestone: --- → 3.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: