Closed
Bug 899334
Opened 11 years ago
Closed 10 years ago
[Mac HiDPI]: HiDPI icons are not respected in system menu
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: Nomis101, Assigned: mstange)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
(deleted),
image/jpeg
|
Details | |
|
(deleted),
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
Screenshot of the issue in Firefox
I've noticed this first for Thunderbird in 898537. It was also mentioned there that this could be a toolkit bug. Than I found out, that Firefox is using also HiDPI images in the system menu (query@2x.png, bookmarksToolbar@2x.png...) and this images are also blurry on my Retian MacBook Pro. The PNGs of this icons are totaly fine and sharp.
Tested with Firefox 22 and the latest nightly.
Interesting to mention is also that the Apple own icon under "Services -> Services Preferences..." is perfectly sharp and not affected.
|
Assignee | |
Comment 1•10 years ago
|
||
The FLAG_SYNC_DECODE change is unrelated but correct and consistent with nsCocoaUtils::CreateNSImageFromImageContainer.
Attachment #8457897 -
Flags: review?(smichaud)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8457897 [details] [diff] [review]
patch
This looks fine to me, and I like the simplification.
But frankly my eyes aren't good enough to tell whether or not it works, HiDPI-wise.
Attachment #8457897 -
Flags: review?(smichaud) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Assignee: nobody → mstange
Status: NEW → ASSIGNED
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•