Andrea Marchesini [:baku] Assignee
	Description • 11 years ago

This macro would be nice to have in order to avoid:

if (rv.Failed()) {
  NS_WARNING(something);
  return somethingelse;
}

Converting IDB components to WebIDL I had to replace many NS_ENSURE_SUCCESS/TRUE to a if statement. Maybe a macro can be useful.

	Andrea Marchesini [:baku] Assignee
	Comment 2 • 11 years ago

I prefer to split the patch in 2.

	Andrea Marchesini [:baku] Assignee
	Comment 4 • 11 years ago

better approach

	Boris Zbarsky [:bzbarsky]
	Comment 5 • 11 years ago

Comment on attachment 783190 [details] [diff] [review]
macro.patch

r=me

	Andrea Marchesini [:baku] Assignee
	Comment 7 • 11 years ago

I cannot use nsCPrintfString because webRTC uses ErrorResult.h and it's external-linked. This new version uses nsCString and ApppendPrintf and it works.

	Andrea Marchesini [:baku] Assignee
	Comment 8 • 11 years ago

 https://tbpl.mozilla.org/?tree=Try&rev=f7fc0751dc66

	Boris Zbarsky [:bzbarsky]
	Comment 9 • 11 years ago

Comment on attachment 783589 [details] [diff] [review]
macro.patch

r=me

	Andrea Marchesini [:baku] Assignee
	Comment 10 • 11 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/42dffbbe9e57

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 11 years ago

https://hg.mozilla.org/mozilla-central/rev/42dffbbe9e57