Closed
Bug 899863
Opened 11 years ago
Closed 11 years ago
ChannelMediaResource should treat resources with a Content-Length as finite
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(1 file)
(deleted),
patch
|
cpearce
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In bug 619752, we talked about treating resources with a Content-Length as finite, but the patch only checks the Content-Duration header (and its aliases). This means when the channel does not support range requests (which includes a Necko response!), and the resource doesn't have a Content-Duration header, we report its duration as infinite (even if we successfully decode a duration from the container).
Assignee | ||
Comment 1•11 years ago
|
||
I meant "Necko cache response".
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #783493 -
Flags: review?(cpearce)
Updated•11 years ago
|
Attachment #783493 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 783493 [details] [diff] [review]
Ensure resources with a Content-Length (that's not the result of a range request) are treated as bounded
[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: none, probably; but needed for Web Audio to work on Aurora
Testing completed (on m-c, etc.): been on m-c for a week or so
Risk to taking this patch (and alternatives if risky): pretty low risk
String or IDL/UUID changes made by this patch: none
Attachment #783493 -
Flags: approval-mozilla-aurora?
Comment 6•11 years ago
|
||
Approval ping? This is blocking a bunch of WebAudio patches to be landed on Aurora.
Flags: needinfo?(lsblakk)
Comment 7•11 years ago
|
||
(In reply to Paul Adenot (:padenot) from comment #6)
> Approval ping? This is blocking a bunch of WebAudio patches to be landed on
> Aurora.
Ping?
Flags: needinfo?(release-mgmt)
Comment 8•11 years ago
|
||
Comment on attachment 783493 [details] [diff] [review]
Ensure resources with a Content-Length (that's not the result of a range request) are treated as bounded
Apologies, at a Stability work week and behind on approvals.
Attachment #783493 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•11 years ago
|
||
status-firefox25:
--- → fixed
status-firefox26:
--- → fixed
Flags: needinfo?(release-mgmt)
Flags: needinfo?(lsblakk)
You need to log in
before you can comment on or make changes to this bug.
Description
•