Closed Bug 900007 Opened 11 years ago Closed 11 years ago

Don't work arrow key on location bar when using autocomplete address

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 + verified

People

(Reporter: tetsuharu, Assigned: ehsan.akhgari)

References

Details

(Keywords: regression)

[Environment] * http://hg.mozilla.org/mozilla-central/rev/c2b375f3a909 * OS X 10.8 [Step To reproduce] 1. Focus location bar. 2. Type some words to lookup history or bookmarks. 3. Display drop down list of matched entries. 4. Input up/down key. [Result] * Drop down list will flash. (Is this caused with updating matched entries?) * I cannot walk across suggested entries. * Focus is staying on location bar input field if I input up/down key repeatedly.
Keywords: regression
status-firefox25: --- → ?
This affects all form input drop downs, not just the location bar's.
Regression-hunted this, caused by bug 893973, verified by a local backout against m-c tip. Masayuki, I think we may want to back out considering how many people are affected...
Blocks: 893973
Flags: needinfo?(masayuki)
Keywords: regressionwindow-wanted
> Regression-hunted this, caused by bug 893973 I assume you're referring to this patch: attachment 778350 [details] [diff] [review] ("nsIWidget::SetInputContext() should check it has focus before calling secure event input API")
(In reply to Steven Michaud from comment #3) > > Regression-hunted this, caused by bug 893973 > > I assume you're referring to this patch: attachment 778350 [details] [diff] [review] > [review] ("nsIWidget::SetInputContext() should check it has focus before > calling secure event input API") No, I believe it's https://hg.mozilla.org/mozilla-central/rev/197b12188f3a. Steven, do you mind logging in to IRC if possible?
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4) > (In reply to Steven Michaud from comment #3) > > > Regression-hunted this, caused by bug 893973 > > > > I assume you're referring to this patch: attachment 778350 [details] [diff] [review] > > [review] ("nsIWidget::SetInputContext() should check it has focus before > > calling secure event input API") > > No, I believe it's https://hg.mozilla.org/mozilla-central/rev/197b12188f3a. > Steven, do you mind logging in to IRC if possible? Correct. Backing that out fixes it.
Sigh, go ahead. I can't imagine why that patch causes trouble, but I'll figure that out later.
I backed out the offending patch: https://hg.mozilla.org/mozilla-central/rev/fd03bb4d1e48
Assignee: nobody → ehsan
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: needinfo?(masayuki)
Keywords: verifyme
Reproduced in nightly 2013-07-31. Verified fixed FF 25b3 Mac OS X 10.8.4
Status: RESOLVED → VERIFIED
status-firefox25: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.