Closed
Bug 900044
Opened 11 years ago
Closed 11 years ago
Get rid of viewport-needs-updating and related code
Categories
(Firefox for Metro Graveyard :: Pan and Zoom, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: bbondy, Assigned: bbondy)
References
Details
Attachments
(2 files)
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
It would simply the code to just call setDisplayPortForElement instead of going back to widget to get the frame metrics values from apzc.
Assignee | ||
Comment 1•11 years ago
|
||
Should make it easier to find the source of the problem in bug 899810
Assignee: nobody → netzen
Attachment #783837 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Updated•11 years ago
|
Comment 2•11 years ago
|
||
Comment on attachment 783837 [details] [diff] [review] Simplify viewport-needs-updating code. rev1 Review of attachment 783837 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Note that you should be able to get rid of MetroCompositorParent entirely, and just move those two lines of code to wherever the compositor is created. ::: widget/windows/winrt/MetroWidget.cpp @@ +810,2 @@ > protected: > nsCOMPtr<MetroWidget> mMetroWidget; You can also get rid mMetroWidget.
Attachment #783837 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Updated•11 years ago
|
Attachment #783837 -
Attachment description: Patch v1. → Simplify viewport-needs-updating code. rev1
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #783878 -
Flags: review?(bugmail.mozilla)
Updated•11 years ago
|
Attachment #783878 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/df7f7c2ab2ba https://hg.mozilla.org/integration/mozilla-inbound/rev/0eff8f365863
OS: Windows 8 → Windows 8 Metro
Target Milestone: --- → Firefox 25
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df7f7c2ab2ba https://hg.mozilla.org/mozilla-central/rev/0eff8f365863
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•