Closed
Bug 900228
Opened 11 years ago
Closed 11 years ago
"TypeError: this.selectedEditor.sourceEditor is null: @resource:///modules/devtools/StyleEditorUI.jsm:154" in green debug mochitest-browser-chrome runs
Categories
(DevTools :: Style Editor, defect)
Tracking
(firefox24 fixed, firefox25 fixed)
RESOLVED
FIXED
Firefox 25
People
(Reporter: emorley, Assigned: harth)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
(deleted),
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
A recently deployed TBPL parser improvement has found a whole bunch of log spam in green debug mochitest-browser-chrome runs.
a) Should these be making the test run fail?
b) We should handle/fix, so we don't spam the annotated failure summary.
eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=25965644&tree=Mozilla-Inbound#error2
{
04:31:35 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Console message: [JavaScript Warning: "Error in parsing value for '-moz-box-ordinal-group'. Declaration dropped." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0 column: 0 source: "-1"}]
04:31:35 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Console message: [JavaScript Warning: "Error in parsing value for '-moz-box-ordinal-group'. Declaration dropped." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0 column: 0 source: "-1"}]
04:31:35 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Console message: [JavaScript Warning: "Error in parsing value for '-moz-box-ordinal-group'. Declaration dropped." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0 column: 0 source: "-1"}]
04:31:35 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_bug_740541_iframes.js | Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/devtools/styleeditor.xul" line: 0}]
04:31:35 INFO - TypeError: this.selectedEditor.sourceEditor is null: @resource:///modules/devtools/StyleEditorUI.jsm:154
}
http://mxr.mozilla.org/mozilla-central/source/browser/devtools/styleeditor/StyleEditorUI.jsm#154
{
147 /**
148 * Handler for debuggee's 'stylesheets-cleared' event. Remove all editors.
149 */
150 _onStyleSheetsCleared: function() {
151 // remember selected sheet and line number for next load
152 if (this.selectedEditor) {
153 let href = this.selectedEditor.styleSheet.href;
154 let {line, col} = this.selectedEditor.sourceEditor.getCaretPosition();
155 this.selectStyleSheet(href, line, col);
156 }
157
158 this._clearStyleSheetEditors();
159 this._view.removeAll();
160
161 this.selectedEditor = null;
162
163 this._root.classList.add("loading");
164 },
}
Assignee | ||
Comment 1•11 years ago
|
||
This shouldn't be too hard to fix, I imagine.
Comment 2•11 years ago
|
||
(In reply to Heather Arthur [:harth] from comment #1)
> This shouldn't be too hard to fix, I imagine.
I assume it's safe to assign this to you then? :)
Assignee: nobody → fayearthur
Assignee | ||
Comment 3•11 years ago
|
||
Fix for the "TypeError: this.selectedEditor.sourceEditor is null". I can't figure out where that -moz-box-ordinal-group is coming from.
Attachment #785430 -
Flags: review?(dcamp)
Updated•11 years ago
|
Attachment #785430 -
Flags: review?(dcamp) → review+
Comment 4•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Comment 6•11 years ago
|
||
(In reply to Heather Arthur [:harth] from comment #3)
Thanks!
Comment 7•11 years ago
|
||
status-firefox24:
--- → fixed
status-firefox25:
--- → fixed
Assuming no QA needed here. Please remove [qa-] from the whiteboard and add the verifyme keyword if this needs QA.
Whiteboard: [qa-]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•