Closed
Bug 900746
Opened 11 years ago
Closed 11 years ago
[fig] Tapping on a visited page item opens the wrong URL (or no URL) if search suggestions are shown
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
(Whiteboard: fixed-fig)
Attachments
(1 file)
|
(deleted),
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
Looks like an off-by-one error.
|
Assignee | |
Comment 1•11 years ago
|
||
We're already accounting for this in SearchAdapter. I moved the getSuggestEngineCount out of that so that I could also use it in onItemClick.
(This patch is built on top of my patch for bug 900148)
Attachment #784673 -
Flags: review?(lucasr.at.mozilla)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 784673 [details] [diff] [review]
patch
Review of attachment 784673 [details] [diff] [review]:
-----------------------------------------------------------------
Nice catch.
Attachment #784673 -
Flags: review?(lucasr.at.mozilla) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Whiteboard: fixed-fig
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•