Closed
Bug 901110
Opened 11 years ago
Closed 11 years ago
IonMonkey: on x64, use a Float32 constants pool
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: bbouvier, Assigned: bbouvier)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
The double constants pool on x64 has been introduced while the Float32 patch was made, so it is an nice and easy follow-up for bug 888109.
I'll take care of it except if somebody beats me to it :)
|
Assignee | |
Comment 1•11 years ago
|
||
We are *this* close to factor all this code in MacroAssembler-x86-shared, if only we didn't have different labels for the uses in the Float and Double structs.
|
||
Comment 2•11 years ago
|
||
Comment on attachment 807043 [details] [diff] [review]
proposed fix
Review of attachment 807043 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jit/x64/MacroAssembler-x64.cpp
@@ +95,5 @@
> bind(&dbl.uses);
> masm.doubleConstant(dbl.value);
> }
>
> + // No need to align on sizeof(float) as we are aligned on sizeof(double);
Not necessarily -- the condition above must be changed to "if (!doubles_.empty() || !floats_.empty())".
Attachment #807043 -
Flags: review?(sstangl) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Nice catch, thanks!
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccbfd1ddb131
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•